* [PATCH] net: dsa: sja1105: Release lock in error case
@ 2019-07-18 2:21 Hariprasad Kelam
2019-07-18 6:53 ` Yuehaibing
0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-07-18 2:21 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, David S. Miller,
netdev, linux-kernel
This patch adds release of unlock in fail case.
Issue identified by coccicheck
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
net/dsa/tag_sja1105.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c
index 1d96c9d..26363d7 100644
--- a/net/dsa/tag_sja1105.c
+++ b/net/dsa/tag_sja1105.c
@@ -216,6 +216,7 @@ static struct sk_buff
if (!skb) {
dev_err_ratelimited(dp->ds->dev,
"Failed to copy stampable skb\n");
+ spin_unlock(&sp->data->meta_lock);
return NULL;
}
sja1105_transfer_meta(skb, meta);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: dsa: sja1105: Release lock in error case
2019-07-18 2:21 [PATCH] net: dsa: sja1105: Release lock in error case Hariprasad Kelam
@ 2019-07-18 6:53 ` Yuehaibing
0 siblings, 0 replies; 2+ messages in thread
From: Yuehaibing @ 2019-07-18 6:53 UTC (permalink / raw)
To: Hariprasad Kelam, Andrew Lunn, Vivien Didelot, Florian Fainelli,
David S. Miller, netdev, linux-kernel
https://patchwork.ozlabs.org/patch/1133135/
This has been fixed.
On 2019/7/18 10:21, Hariprasad Kelam wrote:
> This patch adds release of unlock in fail case.
>
> Issue identified by coccicheck
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> net/dsa/tag_sja1105.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c
> index 1d96c9d..26363d7 100644
> --- a/net/dsa/tag_sja1105.c
> +++ b/net/dsa/tag_sja1105.c
> @@ -216,6 +216,7 @@ static struct sk_buff
> if (!skb) {
> dev_err_ratelimited(dp->ds->dev,
> "Failed to copy stampable skb\n");
> + spin_unlock(&sp->data->meta_lock);
> return NULL;
> }
> sja1105_transfer_meta(skb, meta);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-18 6:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-18 2:21 [PATCH] net: dsa: sja1105: Release lock in error case Hariprasad Kelam
2019-07-18 6:53 ` Yuehaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox