* [Patch net] ife: error out when nla attributes are empty
@ 2019-07-23 4:43 Cong Wang
2019-07-25 18:22 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2019-07-23 4:43 UTC (permalink / raw)
To: netdev; +Cc: Cong Wang, syzbot+fbb5b288c9cb6a2eeac4, Jamal Hadi Salim,
Jiri Pirko
act_ife at least requires TCA_IFE_PARMS, so we have to bail out
when there is no attribute passed in.
Reported-by: syzbot+fbb5b288c9cb6a2eeac4@syzkaller.appspotmail.com
Fixes: ef6980b6becb ("introduce IFE action")
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
net/sched/act_ife.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
index 41d5398dd2f2..3578196d1600 100644
--- a/net/sched/act_ife.c
+++ b/net/sched/act_ife.c
@@ -481,6 +481,11 @@ static int tcf_ife_init(struct net *net, struct nlattr *nla,
int ret = 0;
int err;
+ if (!nla) {
+ NL_SET_ERR_MSG_MOD(extack, "IFE requires attributes to be passed");
+ return -EINVAL;
+ }
+
err = nla_parse_nested_deprecated(tb, TCA_IFE_MAX, nla, ife_policy,
NULL);
if (err < 0)
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Patch net] ife: error out when nla attributes are empty
2019-07-23 4:43 [Patch net] ife: error out when nla attributes are empty Cong Wang
@ 2019-07-25 18:22 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-07-25 18:22 UTC (permalink / raw)
To: xiyou.wangcong; +Cc: netdev, syzbot+fbb5b288c9cb6a2eeac4, jhs, jiri
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Mon, 22 Jul 2019 21:43:00 -0700
> act_ife at least requires TCA_IFE_PARMS, so we have to bail out
> when there is no attribute passed in.
>
> Reported-by: syzbot+fbb5b288c9cb6a2eeac4@syzkaller.appspotmail.com
> Fixes: ef6980b6becb ("introduce IFE action")
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-25 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-23 4:43 [Patch net] ife: error out when nla attributes are empty Cong Wang
2019-07-25 18:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox