* [PATCHv2] libertas: add terminating entry to fw_table
@ 2019-07-23 13:52 Oliver Neukum
0 siblings, 0 replies; only message in thread
From: Oliver Neukum @ 2019-07-23 13:52 UTC (permalink / raw)
To: davem, netdev; +Cc: Oliver Neukum
In case no firmware was found, the system would happily read
and try to load garbage. Terminate the table properly.
V2: change style issues
Fixes: ce84bb69f50e6 ("libertas USB: convert to asynchronous firmware loading")
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+8a8f48672560c8ca59dd@syzkaller.appspotmail.com
---
drivers/net/wireless/marvell/libertas/if_usb.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c
index afac2481909b..fedafdc8b989 100644
--- a/drivers/net/wireless/marvell/libertas/if_usb.c
+++ b/drivers/net/wireless/marvell/libertas/if_usb.c
@@ -50,7 +50,10 @@ static const struct lbs_fw_table fw_table[] = {
{ MODEL_8388, "libertas/usb8388_v5.bin", NULL },
{ MODEL_8388, "libertas/usb8388.bin", NULL },
{ MODEL_8388, "usb8388.bin", NULL },
- { MODEL_8682, "libertas/usb8682.bin", NULL }
+ { MODEL_8682, "libertas/usb8682.bin", NULL },
+
+ /* terminating entry - keep at end */
+ { MODEL_8388, NULL, NULL }
};
static const struct usb_device_id if_usb_table[] = {
--
2.16.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-07-23 13:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-23 13:52 [PATCHv2] libertas: add terminating entry to fw_table Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox