From: David Miller <davem@davemloft.net>
To: skalluru@marvell.com
Cc: netdev@vger.kernel.org, mkalderon@marvell.com, aelior@marvell.com
Subject: Re: [PATCH net-next v3 2/2] qed: Add driver API for flashing the config attributes.
Date: Mon, 29 Jul 2019 11:03:42 -0700 (PDT) [thread overview]
Message-ID: <20190729.110342.703558396264560468.davem@davemloft.net> (raw)
In-Reply-To: <20190728015549.27051-3-skalluru@marvell.com>
From: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Date: Sat, 27 Jul 2019 18:55:49 -0700
> @@ -2268,6 +2330,9 @@ static int qed_nvm_flash(struct qed_dev *cdev, const char *name)
> rc = qed_nvm_flash_image_access(cdev, &data,
> &check_resp);
> break;
> + case QED_NVM_FLASH_CMD_NVM_CFG_ID:
> + rc = qed_nvm_flash_cfg_write(cdev, &data);
> + break;
> default:
> DP_ERR(cdev, "Unknown command %08x\n", cmd_type);
I don't see how any existing portable interface can cause this new code to
actually be used.
You have to explain this to me.
next prev parent reply other threads:[~2019-07-29 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 1:55 [PATCH net-next v3 0/2] qed*: Support for NVM config attributes Sudarsana Reddy Kalluru
2019-07-28 1:55 ` [PATCH net-next v3 1/2] qed: Add API for configuring NVM attributes Sudarsana Reddy Kalluru
2019-07-28 1:55 ` [PATCH net-next v3 2/2] qed: Add driver API for flashing the config attributes Sudarsana Reddy Kalluru
2019-07-29 18:03 ` David Miller [this message]
2019-07-30 3:36 ` Sudarsana Reddy Kalluru
2019-08-05 14:30 ` Ariel Elior
2019-08-12 4:16 ` Sudarsana Reddy Kalluru
2019-07-28 2:13 ` [PATCH net-next v3 0/2] qed*: Support for NVM " David Miller
2019-07-29 7:16 ` Sudarsana Reddy Kalluru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729.110342.703558396264560468.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aelior@marvell.com \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox