From: Vivien Didelot <vivien.didelot@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, f.fainelli@gmail.com, andrew@lunn.ch,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: [PATCH net-next 7/7] net: dsa: mv88e6xxx: add delay in direct SMI wait
Date: Fri, 9 Aug 2019 18:47:59 -0400 [thread overview]
Message-ID: <20190809224759.5743-8-vivien.didelot@gmail.com> (raw)
In-Reply-To: <20190809224759.5743-1-vivien.didelot@gmail.com>
The mv88e6xxx_smi_direct_wait routine is used to wait on indirect
registers access. It is of no exception and must delay between read
attempts, like other wait routines.
Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
---
drivers/net/dsa/mv88e6xxx/smi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/dsa/mv88e6xxx/smi.c b/drivers/net/dsa/mv88e6xxx/smi.c
index 18e87a5a20a3..282fe08db050 100644
--- a/drivers/net/dsa/mv88e6xxx/smi.c
+++ b/drivers/net/dsa/mv88e6xxx/smi.c
@@ -66,6 +66,8 @@ static int mv88e6xxx_smi_direct_wait(struct mv88e6xxx_chip *chip,
if (!!(data & BIT(bit)) == !!val)
return 0;
+
+ usleep_range(1000, 2000);
}
return -ETIMEDOUT;
--
2.22.0
next prev parent reply other threads:[~2019-08-09 22:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 22:47 [PATCH net-next 0/7] net: dsa: mv88e6xxx: prepare Wait Bit operation Vivien Didelot
2019-08-09 22:47 ` [PATCH net-next 1/7] net: dsa: mv88e6xxx: wait for 88E6185 PPU disabled Vivien Didelot
2019-08-09 22:47 ` [PATCH net-next 2/7] net: dsa: mv88e6xxx: introduce wait mask routine Vivien Didelot
2019-08-09 22:47 ` [PATCH net-next 3/7] net: dsa: mv88e6xxx: introduce wait bit routine Vivien Didelot
2019-08-09 22:47 ` [PATCH net-next 4/7] net: dsa: mv88e6xxx: wait for AVB Busy bit Vivien Didelot
2019-08-09 22:47 ` [PATCH net-next 5/7] net: dsa: mv88e6xxx: remove wait and update routines Vivien Didelot
2019-08-09 22:47 ` [PATCH net-next 6/7] net: dsa: mv88e6xxx: fix SMI bit checking Vivien Didelot
2019-08-09 22:47 ` Vivien Didelot [this message]
2019-08-12 4:27 ` [PATCH net-next 0/7] net: dsa: mv88e6xxx: prepare Wait Bit operation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809224759.5743-8-vivien.didelot@gmail.com \
--to=vivien.didelot@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox