From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Quentin Monnet <quentin.monnet@netronome.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
oss-drivers@netronome.com, Lorenz Bauer <lmb@cloudflare.com>,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH bpf-next 0/3] tools: bpftool: improve bpftool build experience
Date: Thu, 29 Aug 2019 10:25:54 -0700 [thread overview]
Message-ID: <20190829102554.2fdbc80b@cakuba.netronome.com> (raw)
In-Reply-To: <20190829105645.12285-1-quentin.monnet@netronome.com>
On Thu, 29 Aug 2019 11:56:42 +0100, Quentin Monnet wrote:
> Hi,
> This set attempts to make it easier to build bpftool, in particular when
> passing a specific output directory. This is a follow-up to the
> conversation held last month by Lorenz, Ilya and Jakub [0].
>
> The first patch is a minor fix to bpftool's Makefile, regarding the
> retrieval of kernel version (which currently prints a non-relevant make
> warning on some invocations).
>
> Second patch improves the Makefile commands to support more "make"
> invocations, or to fix building with custom output directory. On Jakub's
> suggestion, a script is also added to BPF selftests in order to keep track
> of the supported build variants.
>
> At last, third patch is a sligthly modified version of Ilya's fix regarding
> libbpf.a appearing twice on the linking command for bpftool.
>
> [0] https://lore.kernel.org/bpf/CACAyw9-CWRHVH3TJ=Tke2x8YiLsH47sLCijdp=V+5M836R9aAA@mail.gmail.com/
I think Ilya has a point, but otherwise looks good to me :)
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
prev parent reply other threads:[~2019-08-29 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 10:56 [PATCH bpf-next 0/3] tools: bpftool: improve bpftool build experience Quentin Monnet
2019-08-29 10:56 ` [PATCH bpf-next 1/3] tools: bpftool: ignore make built-in rules for getting kernel version Quentin Monnet
2019-08-29 10:56 ` [PATCH bpf-next 2/3] tools: bpftool: improve and check builds for different make invocations Quentin Monnet
2019-08-29 16:03 ` Ilya Leoshkevich
2019-08-30 10:58 ` Quentin Monnet
2019-08-29 10:56 ` [PATCH bpf-next 3/3] tools: bpftool: do not link twice against libbpf.a in Makefile Quentin Monnet
2019-08-29 17:25 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829102554.2fdbc80b@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=iii@linux.ibm.com \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox