Netdev List
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Quentin Monnet <quentin.monnet@netronome.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	bpf@vger.kernel.org, netdev@vger.kernel.org,
	oss-drivers@netronome.com, Lorenz Bauer <lmb@cloudflare.com>,
	Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH bpf-next 2/3] tools: bpftool: improve and check builds for different make invocations
Date: Thu, 29 Aug 2019 18:03:11 +0200	[thread overview]
Message-ID: <C90F7A80-D2E9-401B-8BFC-47C22A44ADAC@linux.ibm.com> (raw)
In-Reply-To: <20190829105645.12285-3-quentin.monnet@netronome.com>

> Am 29.08.2019 um 12:56 schrieb Quentin Monnet <quentin.monnet@netronome.com>:
> 
> +make_and_clean() {
> +	echo -e "\$PWD:    $PWD"
> +	echo -e "command: make -s $* >/dev/null"
> +	make $J -s $* >/dev/null

Would it make sense to set ERROR=1 if make produces a bpftool binary,
but still fails with a non-zero RC for whatever reason?


  reply	other threads:[~2019-08-29 16:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 10:56 [PATCH bpf-next 0/3] tools: bpftool: improve bpftool build experience Quentin Monnet
2019-08-29 10:56 ` [PATCH bpf-next 1/3] tools: bpftool: ignore make built-in rules for getting kernel version Quentin Monnet
2019-08-29 10:56 ` [PATCH bpf-next 2/3] tools: bpftool: improve and check builds for different make invocations Quentin Monnet
2019-08-29 16:03   ` Ilya Leoshkevich [this message]
2019-08-30 10:58     ` Quentin Monnet
2019-08-29 10:56 ` [PATCH bpf-next 3/3] tools: bpftool: do not link twice against libbpf.a in Makefile Quentin Monnet
2019-08-29 17:25 ` [PATCH bpf-next 0/3] tools: bpftool: improve bpftool build experience Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C90F7A80-D2E9-401B-8BFC-47C22A44ADAC@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=lmb@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=quentin.monnet@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox