* [PATCH net v2] bridge/mdb: remove wrong use of NLM_F_MULTI
@ 2019-09-06 9:47 Nicolas Dichtel
2019-09-10 8:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Dichtel @ 2019-09-06 9:47 UTC (permalink / raw)
To: davem; +Cc: roopa, netdev, bridge, Nicolas Dichtel, Nikolay Aleksandrov
NLM_F_MULTI must be used only when a NLMSG_DONE message is sent at the end.
In fact, NLMSG_DONE is sent only at the end of a dump.
Libraries like libnl will wait forever for NLMSG_DONE.
Fixes: 949f1e39a617 ("bridge: mdb: notify on router port add and del")
CC: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
---
v2:
add netdev and bridge ml :D
remove Satish Ashok <sashok@cumulusnetworks.com> (its mail bounces)
net/bridge/br_mdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index bf6acd34234d..63f9c08625f0 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -437,7 +437,7 @@ static int nlmsg_populate_rtr_fill(struct sk_buff *skb,
struct nlmsghdr *nlh;
struct nlattr *nest;
- nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), NLM_F_MULTI);
+ nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), 0);
if (!nlh)
return -EMSGSIZE;
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net v2] bridge/mdb: remove wrong use of NLM_F_MULTI
2019-09-06 9:47 [PATCH net v2] bridge/mdb: remove wrong use of NLM_F_MULTI Nicolas Dichtel
@ 2019-09-10 8:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-09-10 8:13 UTC (permalink / raw)
To: nicolas.dichtel; +Cc: roopa, netdev, bridge, nikolay
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Fri, 6 Sep 2019 11:47:02 +0200
> NLM_F_MULTI must be used only when a NLMSG_DONE message is sent at the end.
> In fact, NLMSG_DONE is sent only at the end of a dump.
>
> Libraries like libnl will wait forever for NLMSG_DONE.
>
> Fixes: 949f1e39a617 ("bridge: mdb: notify on router port add and del")
> CC: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-10 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-06 9:47 [PATCH net v2] bridge/mdb: remove wrong use of NLM_F_MULTI Nicolas Dichtel
2019-09-10 8:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox