From: David Miller <davem@davemloft.net>
To: richardcochran@gmail.com
Cc: felipe.balbi@linux.intel.com, christopher.s.hall@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] PTP: add support for one-shot output
Date: Thu, 12 Sep 2019 19:01:37 +0200 (CEST) [thread overview]
Message-ID: <20190912.190137.820514851969442445.davem@davemloft.net> (raw)
In-Reply-To: <20190912165609.GA1439@localhost>
From: Richard Cochran <richardcochran@gmail.com>
Date: Thu, 12 Sep 2019 09:56:09 -0700
> On Wed, Sep 11, 2019 at 09:16:22AM +0300, Felipe Balbi wrote:
>> Some controllers allow for a one-shot output pulse, in contrast to
>> periodic output. Now that we have extensible versions of our IOCTLs, we
>> can finally make use of the 'flags' field to pass a bit telling driver
>> that if we want one-shot pulse output.
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>> ---
>>
>> Changes since v3:
>> - Remove bogus bitwise negation
>>
>> Changes since v2:
>> - Add _PEROUT_ to bit macro
>>
>> Changes since v1:
>> - remove comment from .flags field
>
> Reviewed-by: Richard Cochran <richardcochran@gmail.com>
>
> @davem, these two are good to go!
Ok, thanks for reviewing.
next prev parent reply other threads:[~2019-09-12 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 6:16 [PATCH v4 1/2] PTP: introduce new versions of IOCTLs Felipe Balbi
2019-09-11 6:16 ` [PATCH v4 2/2] PTP: add support for one-shot output Felipe Balbi
2019-09-12 16:56 ` Richard Cochran
2019-09-12 17:01 ` David Miller [this message]
2019-09-13 13:57 ` David Miller
2019-09-24 19:23 ` Keller, Jacob E
2019-09-24 20:23 ` Hall, Christopher S
2019-09-24 21:16 ` Keller, Jacob E
2019-09-24 21:53 ` Keller, Jacob E
2019-09-13 13:57 ` [PATCH v4 1/2] PTP: introduce new versions of IOCTLs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912.190137.820514851969442445.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christopher.s.hall@intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox