From: David Miller <davem@davemloft.net>
To: bjorn@mork.no
Cc: netdev@vger.kernel.org, oliver@neukum.org,
linux-usb@vger.kernel.org, larsm17@gmail.com
Subject: Re: [PATCH net,stable] cdc_ether: fix rndis support for Mediatek based smartphones
Date: Fri, 13 Sep 2019 21:09:14 +0100 (WEST) [thread overview]
Message-ID: <20190913.210914.459044600119292225.davem@davemloft.net> (raw)
In-Reply-To: <20190912084200.6359-1-bjorn@mork.no>
From: Bjørn Mork <bjorn@mork.no>
Date: Thu, 12 Sep 2019 10:42:00 +0200
> A Mediatek based smartphone owner reports problems with USB
> tethering in Linux. The verbose USB listing shows a rndis_host
> interface pair (e0/01/03 + 10/00/00), but the driver fails to
> bind with
>
> [ 355.960428] usb 1-4: bad CDC descriptors
>
> The problem is a failsafe test intended to filter out ACM serial
> functions using the same 02/02/ff class/subclass/protocol as RNDIS.
> The serial functions are recognized by their non-zero bmCapabilities.
>
> No RNDIS function with non-zero bmCapabilities were known at the time
> this failsafe was added. But it turns out that some Wireless class
> RNDIS functions are using the bmCapabilities field. These functions
> are uniquely identified as RNDIS by their class/subclass/protocol, so
> the failing test can safely be disabled. The same applies to the two
> types of Misc class RNDIS functions.
>
> Applying the failsafe to Communication class functions only retains
> the original functionality, and fixes the problem for the Mediatek based
> smartphone.
>
> Tow examples of CDC functional descriptors with non-zero bmCapabilities
> from Wireless class RNDIS functions are:
...
> The Mediatek example is believed to apply to most smartphones with
> Mediatek firmware. The ZTE example is most likely also part of a larger
> family of devices/firmwares.
>
> Suggested-by: Lars Melin <larsm17@gmail.com>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-09-13 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 8:42 [PATCH net,stable] cdc_ether: fix rndis support for Mediatek based smartphones Bjørn Mork
2019-09-13 20:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913.210914.459044600119292225.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bjorn@mork.no \
--cc=larsm17@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox