From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Andrew Bowers <andrewx.bowers@intel.com>
Subject: Re: [net-next 05/15] ice: fix stack leakage
Date: Thu, 21 Nov 2019 14:25:48 -0800 [thread overview]
Message-ID: <20191121142548.4bb62c55@cakuba.netronome.com> (raw)
In-Reply-To: <20191121074612.3055661-6-jeffrey.t.kirsher@intel.com>
On Wed, 20 Nov 2019 23:46:02 -0800, Jeff Kirsher wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> In the case of an invalid virtchannel request the driver
> would return uninitialized data to the VF from the PF stack
> which is a bug. Fix by initializing the stack variable
> earlier in the function before any return paths can be taken.
I'd argue users may not want hypervisor stack to get leaked into the
VMs, and therefore this should really have a fixes tag...
next prev parent reply other threads:[~2019-11-21 22:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 7:45 [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-11-20 Jeff Kirsher
2019-11-21 7:45 ` [net-next 01/15] ice: Store number of functions for the device Jeff Kirsher
2019-11-21 7:45 ` [net-next 02/15] ice: Correct capabilities reporting of max TCs Jeff Kirsher
2019-11-21 7:46 ` [net-next 03/15] ice: Disallow VF VLAN opcodes if VLAN offloads disabled Jeff Kirsher
2019-11-21 7:46 ` [net-next 04/15] ice: Don't modify stripping for add/del VLANs on VF Jeff Kirsher
2019-11-21 7:46 ` [net-next 05/15] ice: fix stack leakage Jeff Kirsher
2019-11-21 22:25 ` Jakub Kicinski [this message]
2019-11-21 22:37 ` David Miller
2019-11-21 23:07 ` Jeff Kirsher
2019-11-21 7:46 ` [net-next 06/15] ice: Only disable VF state when freeing each VF resources Jeff Kirsher
2019-11-21 7:46 ` [net-next 07/15] ice: Fix setting coalesce to handle DCB configuration Jeff Kirsher
2019-11-21 7:46 ` [net-next 08/15] ice: Refactor removal of VLAN promiscuous rules Jeff Kirsher
2019-11-21 7:46 ` [net-next 09/15] ice: Do not use devm* functions for local uses Jeff Kirsher
2019-11-21 7:46 ` [net-next 10/15] ice: Add ice_pf_to_dev(pf) macro Jeff Kirsher
2019-11-21 7:46 ` [net-next 11/15] ice: add helpers for virtchnl Jeff Kirsher
2019-11-21 7:46 ` [net-next 12/15] ice: implement VF stats NDO Jeff Kirsher
2019-11-21 7:46 ` [net-next 13/15] ice: Implement ethtool ops for channels Jeff Kirsher
2019-11-21 22:42 ` Jakub Kicinski
2019-11-22 7:09 ` Jeff Kirsher
2019-11-22 17:44 ` Jakub Kicinski
2019-11-21 7:46 ` [net-next 14/15] ice: remove pointless NULL check of port_info Jeff Kirsher
2019-11-21 7:46 ` [net-next 15/15] ice: Update FW API minor version Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121142548.4bb62c55@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=andrewx.bowers@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox