From: Sabrina Dubroca <sd@queasysnail.net>
To: David Ahern <dsahern@gmail.com>
Cc: Antoine Tenart <antoine.tenart@bootlin.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next 2/2] macsec: add support for changing the offloading mode
Date: Tue, 28 Jan 2020 11:36:02 +0100 [thread overview]
Message-ID: <20200128103602.GA635468@bistromath.localdomain> (raw)
In-Reply-To: <f1acfe75-43c7-38ca-7b93-16862b40f49e@gmail.com>
2020-01-27, 09:44:09 -0700, David Ahern wrote:
> On 1/20/20 1:18 PM, Antoine Tenart wrote:
> > MacSEC can now be offloaded to specialized hardware devices. Offloading
> > is off by default when creating a new MACsec interface, but the mode can
> > be updated at runtime. This patch adds a new subcommand,
> > `ip macsec offload`, to allow users to select the offloading mode of a
> > MACsec interface. It takes the mode to switch to as an argument, which
> > can for now either be 'off' or 'phy':
> >
> > # ip macsec offload macsec0 phy
> > # ip macsec offload macsec0 off
>
> seems like this should fall under 'ip macsec set ...'
>
> Sabrina: thoughts?
The difference is that the other "set" commands also have an
"add"/"del" counterpart. "offload" would only have "set", so that
would be a bit inconsistent. Either way seems acceptable.
Another possibility is to see offloading as a property of the macsec
interface. Then it could be set on creation (ip link add ... type
macsec offload phy), or modified by link change, like other
device-wide properties (say, icvlen). But then I guess the netlink API
would need to be different... In that case, the "offload: X" line of
the output should also be integrated with the other device properties
(icvlen etc).
--
Sabrina
next prev parent reply other threads:[~2020-01-28 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 20:18 [PATCH iproute2-next 0/2] macsec: add offloading support Antoine Tenart
2020-01-20 20:18 ` [PATCH iproute2-next 1/2] macsec: report the offloading mode currently selected Antoine Tenart
2020-01-27 16:41 ` David Ahern
2020-01-29 11:12 ` Antoine Tenart
2020-01-20 20:18 ` [PATCH iproute2-next 2/2] macsec: add support for changing the offloading mode Antoine Tenart
2020-01-27 16:44 ` David Ahern
2020-01-28 10:36 ` Sabrina Dubroca [this message]
2020-01-28 10:36 ` [PATCH iproute2-next 0/2] macsec: add offloading support Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128103602.GA635468@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=antoine.tenart@bootlin.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox