From: Sabrina Dubroca <sd@queasysnail.net>
To: Antoine Tenart <antoine.tenart@bootlin.com>
Cc: dsahern@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next 0/2] macsec: add offloading support
Date: Tue, 28 Jan 2020 11:36:06 +0100 [thread overview]
Message-ID: <20200128103606.GA635664@bistromath.localdomain> (raw)
In-Reply-To: <20200120201823.887937-1-antoine.tenart@bootlin.com>
2020-01-20, 21:18:21 +0100, Antoine Tenart wrote:
> If a mode isn't supported, `ip macsec offload` will report an issue
> (-EOPNOTSUPP).
>
> One thing not supported in this series would be the ability to list all
> supported modes (for now 'off' and 'phy') depending on the h/w interface
> capabilities. This can come up in a later patch, as this is not critical
> to get the feature used, but I would like this to be compatible with the
> current series. I can think of 2 possibilities: either through
> `ip macsec show` or through `ip macsec offload` (for example when no
> argument is given). What are your thoughts on this?
I don't think that's really helpful. The device could change between
listing available modes and enabling offloading. The failure of "ip
macsec offload blah" (or whatever the command ends up being) will do
the same job anyway.
--
Sabrina
next prev parent reply other threads:[~2020-01-28 10:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 20:18 [PATCH iproute2-next 0/2] macsec: add offloading support Antoine Tenart
2020-01-20 20:18 ` [PATCH iproute2-next 1/2] macsec: report the offloading mode currently selected Antoine Tenart
2020-01-27 16:41 ` David Ahern
2020-01-29 11:12 ` Antoine Tenart
2020-01-20 20:18 ` [PATCH iproute2-next 2/2] macsec: add support for changing the offloading mode Antoine Tenart
2020-01-27 16:44 ` David Ahern
2020-01-28 10:36 ` Sabrina Dubroca
2020-01-28 10:36 ` Sabrina Dubroca [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-24 8:38 [PATCH iproute2-next 0/2] macsec: add offloading support Igor Russkikh
2020-04-26 18:33 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128103606.GA635664@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=antoine.tenart@bootlin.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox