From: Jakub Kicinski <kuba@kernel.org>
To: subashab@codeaurora.org
Cc: Taehee Yoo <ap420073@gmail.com>,
davem@davemloft.net, stranche@codeaurora.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module
Date: Wed, 4 Mar 2020 18:53:47 -0800 [thread overview]
Message-ID: <20200304185347.797972fb@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <eb4fa65d10a8b1f81be44bcb4e3b6a43@codeaurora.org>
On Wed, 04 Mar 2020 16:43:58 -0700 subashab@codeaurora.org wrote:
> On 2020-03-04 16:24, Taehee Yoo wrote:
> > This patchset is to cleanup rmnet module code.
> >
> > 1. The first patch is to add module alias
> > rmnet module can not be loaded automatically because there is no
> > alias name.
> >
> > 2. The second patch is to add extack error message code.
> > When rmnet netlink command fails, it doesn't print any error message.
> > So, users couldn't know the exact reason.
> > In order to tell the exact reason to the user, the extack error message
> > is used in this patch.
> >
> > 3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC.
> > In the sleepable context, GFP_KERNEL can be used.
> > So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.
> >
> > Change log:
> > - v1->v2: change error message in the second patch.
>
> For the series:
>
> Acked-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
LGTM as well, thanks!
next prev parent reply other threads:[~2020-03-05 2:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 23:24 [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module Taehee Yoo
2020-03-04 23:43 ` subashab
2020-03-05 2:53 ` Jakub Kicinski [this message]
2020-03-05 19:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304185347.797972fb@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stranche@codeaurora.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox