From: Jakub Kicinski <kuba@kernel.org>
To: Rohit Maheshwari <rohitm@chelsio.com>
Cc: borisp@mellanox.com, netdev@vger.kernel.org, davem@davemloft.net,
herbert@gondor.apana.org.au, secdev@chelsio.com,
varun@chelsio.com
Subject: Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del callback
Date: Mon, 9 Mar 2020 16:10:21 -0700 [thread overview]
Message-ID: <20200309161021.0e58ee24@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20200309160526.26845f55@kicinski-fedora-PC1C0HJN>
On Mon, 9 Mar 2020 16:05:26 -0700 Jakub Kicinski wrote:
> On Sat, 7 Mar 2020 20:06:03 +0530 Rohit Maheshwari wrote:
> > A new macro is defined to enable ktls tx offload support on Chelsio
> > T6 adapter. And if this macro is enabled, cxgb4 will send mailbox to
> > enable or disable ktls settings on HW.
> > In chcr, enabled tx offload flag in netdev and registered tls_dev_add
> > and tls_dev_del.
> >
> > v1->v2:
> > - mark tcb state to close in tls_dev_del.
> > - u_ctx is now picked from adapter structure.
> > - clear atid in case of failure.
> > - corrected ULP_CRYPTO_KTLS_INLINE value.
> >
> > v2->v3:
> > - add empty line after variable declaration.
> > - local variable declaration in reverse christmas tree ordering.
> >
> > Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com>
>
> What ciphers do you support? You never check cipher type.
Ugh, next patch. Which contains three changes and half of what should
have been here.
And the driver lives in drivers/crypto for some inexplicable reason.
next prev parent reply other threads:[~2020-03-09 23:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 14:36 [PATCH net-next v4 0/6] cxgb4/chcr: ktls tx ofld support on T6 adapter Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del callback Rohit Maheshwari
2020-03-09 23:05 ` Jakub Kicinski
2020-03-09 23:10 ` Jakub Kicinski [this message]
2020-03-10 2:34 ` Herbert Xu
2020-03-10 5:32 ` rohit maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 2/6] cxgb4/chcr: Save tx keys and handle HW response Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 3/6] cxgb4/chcr: complete record tx handling Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 4/6] chcr: handle partial end part of a record Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 5/6] chcr: Handle first or middle part of record Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 6/6] cxgb4/chcr: Add ipv6 support and statistics Rohit Maheshwari
2020-03-09 23:00 ` Jakub Kicinski
2020-03-10 5:37 ` rohit maheshwari
2020-03-09 4:16 ` [PATCH net-next v4 0/6] cxgb4/chcr: ktls tx ofld support on T6 adapter David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309161021.0e58ee24@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=rohitm@chelsio.com \
--cc=secdev@chelsio.com \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox