From: rohit maheshwari <rohitm@chelsio.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Jakub Kicinski <kuba@kernel.org>
Cc: borisp@mellanox.com, netdev@vger.kernel.org, davem@davemloft.net,
secdev@chelsio.com, varun@chelsio.com
Subject: Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del callback
Date: Tue, 10 Mar 2020 11:02:42 +0530 [thread overview]
Message-ID: <b8d68538-a9f2-66a3-411a-ee53d7f7abb2@chelsio.com> (raw)
In-Reply-To: <20200310023428.GB18504@gondor.apana.org.au>
On 10/03/20 8:04 AM, Herbert Xu wrote:
> On Mon, Mar 09, 2020 at 04:10:21PM -0700, Jakub Kicinski wrote:
>> And the driver lives in drivers/crypto for some inexplicable reason.
> Indeed, and this driver scares me :)
>
> I believe it was added to drivers/crypto because it contained
> code that hooks into the crypto API to provide crypto algorithms.
> At the same time the driver also provides higher-level offload
> directly through the network stack.
>
> The problem with this arrangement is that a lot of network-related
> code gets into the driver with almost no review.
>
> I think it would make much more sense to move the whole driver
> (back) into drivers/net. There is no reason why it couldn't
> continue to provide crypto API implementations from drivers/net.
>
> Thanks,
Since chtls (inline TOE TLS) was part of drivers/crypto, so I thought of
putting this code there as well. You are right, it makes sense to keep
only chcr co-processor part in drivers/crypto dirctory and shift complete
nic-tls and chtls code in drivers/net directory. We'll work on it ASAP.
next prev parent reply other threads:[~2020-03-10 5:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 14:36 [PATCH net-next v4 0/6] cxgb4/chcr: ktls tx ofld support on T6 adapter Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del callback Rohit Maheshwari
2020-03-09 23:05 ` Jakub Kicinski
2020-03-09 23:10 ` Jakub Kicinski
2020-03-10 2:34 ` Herbert Xu
2020-03-10 5:32 ` rohit maheshwari [this message]
2020-03-07 14:36 ` [PATCH net-next v4 2/6] cxgb4/chcr: Save tx keys and handle HW response Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 3/6] cxgb4/chcr: complete record tx handling Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 4/6] chcr: handle partial end part of a record Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 5/6] chcr: Handle first or middle part of record Rohit Maheshwari
2020-03-07 14:36 ` [PATCH net-next v4 6/6] cxgb4/chcr: Add ipv6 support and statistics Rohit Maheshwari
2020-03-09 23:00 ` Jakub Kicinski
2020-03-10 5:37 ` rohit maheshwari
2020-03-09 4:16 ` [PATCH net-next v4 0/6] cxgb4/chcr: ktls tx ofld support on T6 adapter David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8d68538-a9f2-66a3-411a-ee53d7f7abb2@chelsio.com \
--to=rohitm@chelsio.com \
--cc=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=secdev@chelsio.com \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox