From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <snelson@pensando.io>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 4/6] ionic: ignore eexist on rx filter add
Date: Fri, 20 Mar 2020 10:16:30 -0700 [thread overview]
Message-ID: <20200320101630.13d80223@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <e681ace5-bd70-4f7b-144f-3d5c0d140d12@pensando.io>
On Thu, 19 Mar 2020 22:21:35 -0700 Shannon Nelson wrote:
> On 3/19/20 8:43 PM, Jakub Kicinski wrote:
> > On Thu, 19 Mar 2020 19:31:51 -0700 Shannon Nelson wrote:
> >> Don't worry if the rx filter add firmware request fails on
> >> EEXIST, at least we know the filter is there. Same for
> >> the delete request, at least we know it isn't there.
> >>
> >> Fixes: 2a654540be10 ("ionic: Add Rx filter and rx_mode ndo support")
> >> Signed-off-by: Shannon Nelson <snelson@pensando.io>
> > Why could the filter be there? Seems like the FW shouldn't have filters
> > the driver didn't add, could a flush/reset command help to start from
> > clean state?
> >
> > Just curious.
> Because there are use cases where the device is configured by an
> external centralized agent and may have already stuck the appropriate
> filters into the its list.
Thanks, seems a little leaky for the host to be able to probe the state
installed by the agent, but it does explain the need.
next prev parent reply other threads:[~2020-03-20 17:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 2:31 [PATCH net-next 0/6] ionic error recovery fixes Shannon Nelson
2020-03-20 2:31 ` [PATCH net-next 1/6] ionic: add timeout error checking for queue disable Shannon Nelson
2020-03-20 2:31 ` [PATCH net-next 2/6] ionic: leave dev cmd request contents alone on FW timeout Shannon Nelson
2020-03-20 2:31 ` [PATCH net-next 3/6] ionic: only save good lif dentry Shannon Nelson
2020-03-20 2:31 ` [PATCH net-next 4/6] ionic: ignore eexist on rx filter add Shannon Nelson
2020-03-20 3:43 ` Jakub Kicinski
2020-03-20 5:21 ` Shannon Nelson
2020-03-20 17:16 ` Jakub Kicinski [this message]
2020-03-20 2:31 ` [PATCH net-next 5/6] ionic: clean irq affinity on queue deinit Shannon Nelson
2020-03-20 2:31 ` [PATCH net-next 6/6] ionic: check for NULL structs on teardown Shannon Nelson
2020-03-20 3:46 ` [PATCH net-next 0/6] ionic error recovery fixes Jakub Kicinski
2020-03-20 5:21 ` Shannon Nelson
2020-03-22 2:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320101630.13d80223@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox