From: David Miller <davem@davemloft.net>
To: brouer@redhat.com
Cc: netdev@vger.kernel.org, me@tobin.cc
Subject: Re: [PATCH net-next] net: fix skb_panic to output real address
Date: Fri, 01 May 2020 15:20:15 -0700 (PDT) [thread overview]
Message-ID: <20200501.152015.1993781585716424031.davem@davemloft.net> (raw)
In-Reply-To: <158800546361.1962096.4535216438507756179.stgit@firesoul>
From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Mon, 27 Apr 2020 18:37:43 +0200
> In skb_panic() the real pointer values are really needed to diagnose
> issues, e.g. data and head are related (to calculate headroom). The
> hashed versions of the addresses doesn't make much sense here. The
> patch use the printk specifier %px to print the actual address.
>
> The printk documentation on %px:
> https://www.kernel.org/doc/html/latest/core-api/printk-formats.html#unmodified-addresses
>
> Fixes: ad67b74d2469 ("printk: hash addresses printed with %p")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Applied.
prev parent reply other threads:[~2020-05-01 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 16:37 [PATCH net-next] net: fix skb_panic to output real address Jesper Dangaard Brouer
2020-05-01 22:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501.152015.1993781585716424031.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=me@tobin.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox