From: Dejin Zheng <zhengdejin5@gmail.com>
To: Jonathan Richardson <jonathan.richardson@broadcom.com>
Cc: davem@davemloft.net, Scott Branden <scott.branden@broadcom.com>,
Ray Jui <ray.jui@broadcom.com>,
netdev@vger.kernel.org
Subject: Re: bgmac-enet driver broken in 5.7
Date: Tue, 5 May 2020 10:21:43 +0800 [thread overview]
Message-ID: <20200505022143.GA31724@nuc8i5> (raw)
In-Reply-To: <CAHrpVsU5LO8P74r=9hmfFcoX_zLc8fYAQxmV8J0THbM6OJWfyQ@mail.gmail.com>
On Mon, May 04, 2020 at 05:37:18PM -0700, Jonathan Richardson wrote:
> On Mon, May 4, 2020 at 5:30 PM Dejin Zheng <zhengdejin5@gmail.com> wrote:
> >
> > On Mon, May 04, 2020 at 12:32:55PM -0700, Jonathan Richardson wrote:
> > > Hi,
> > >
> > > Commit d7a5502b0bb8b (net: broadcom: convert to
> > > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
> > > probe fails with -22. idm_base and nicpm_base were optional. Now they
> > > are mandatory. Our upstream dtb doesn't have them defined. I'm not
> > > clear on why this change was made. Can it be reverted?
> > >
> > Jon, I am so sorry for that, I will submit a cl to reverted it to make
> > idm_base and nicpm_base as optional. sorry!
>
> No problem. I'll let you submit the fix then. Thanks for taking care of it.
Thank you very much for giving me this opportunity to deal with my
mistakes. at the same time, I apologize for the trouble to bring you.
now, I have submitted a cl is here:
http://patchwork.ozlabs.org/project/netdev/patch/20200505020329.31638-1-zhengdejin5@gmail.com/
I hope it solves this problem. sorry! I will be more careful with each
new patch. Thanks!
BR,
Dejin
prev parent reply other threads:[~2020-05-05 2:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 19:32 bgmac-enet driver broken in 5.7 Jonathan Richardson
2020-05-04 20:19 ` Florian Fainelli
2020-05-04 20:24 ` Jonathan Richardson
2020-05-04 20:36 ` Florian Fainelli
2020-05-05 0:30 ` Dejin Zheng
2020-05-05 0:37 ` Jonathan Richardson
2020-05-05 2:21 ` Dejin Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505022143.GA31724@nuc8i5 \
--to=zhengdejin5@gmail.com \
--cc=davem@davemloft.net \
--cc=jonathan.richardson@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox