From: Florian Fainelli <f.fainelli@gmail.com>
To: Jonathan Richardson <jonathan.richardson@broadcom.com>,
zhengdejin5@gmail.com
Cc: davem@davemloft.net, Scott Branden <scott.branden@broadcom.com>,
Ray Jui <ray.jui@broadcom.com>,
netdev@vger.kernel.org
Subject: Re: bgmac-enet driver broken in 5.7
Date: Mon, 4 May 2020 13:19:58 -0700 [thread overview]
Message-ID: <87b7e9f5-39d3-5523-83da-71361cf193f5@gmail.com> (raw)
In-Reply-To: <CAHrpVsUFBTEj9VB_aURRB+=w68nybiKxkEX+kO2pe+O9GGyzBg@mail.gmail.com>
On 5/4/2020 12:32 PM, Jonathan Richardson wrote:
> Hi,
>
> Commit d7a5502b0bb8b (net: broadcom: convert to
> devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
> probe fails with -22. idm_base and nicpm_base were optional. Now they
> are mandatory. Our upstream dtb doesn't have them defined. I'm not
> clear on why this change was made. Can it be reverted?
You don't get a change reverted by just asking for it, you have to
submit a revert to get that done can you do that?
--
Florian
next prev parent reply other threads:[~2020-05-04 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 19:32 bgmac-enet driver broken in 5.7 Jonathan Richardson
2020-05-04 20:19 ` Florian Fainelli [this message]
2020-05-04 20:24 ` Jonathan Richardson
2020-05-04 20:36 ` Florian Fainelli
2020-05-05 0:30 ` Dejin Zheng
2020-05-05 0:37 ` Jonathan Richardson
2020-05-05 2:21 ` Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87b7e9f5-39d3-5523-83da-71361cf193f5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=jonathan.richardson@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox