pull request: bluetooth-next 2020-05-09

pull request: bluetooth-next 2020-05-09

[Johan Hedberg]

[-- Attachment #1: Type: text/plain, Size: 4486 bytes --]

Hi Dave,

Here's another set of Bluetooth patches for the 5.8 kernel:

 - Add support for Intel Typhoon Peak device (8087:0032)
 - Add device tree bindings for Realtek RTL8723BS device
 - Add device tree bindings for Qualcomm QCA9377 device
 - Add support for experimental features configuration through mgmt
 - Multiple fixes & cleanups to the btbcm driver
 - Add support for LE scatternet topology for selected devices
 - A few other smaller fixes & cleanups

Please let me know if there are any issues pulling. Thanks.

Johan

---
The following changes since commit 44dd5efc97dae0dc09ea9316597826c8b0fd1578:

  Merge branch 'Support-programmable-pins-for-Ocelot-PTP-driver' (2020-04-21 15:38:34 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git for-upstream

for you to fetch changes up to c947c948df52c24d8477a36a9706ebfa26430ea4:

  Bluetooth: Introduce debug feature when dynamic debug is disabled (2020-05-08 11:53:44 +0300)

----------------------------------------------------------------
Alain Michaud (3):
      Bluetooth: Adding driver and quirk defs for multi-role LE
      Bluetooth: allow scatternet connections if supported.
      Bluetooth: btusb: Adding support for LE scatternet to Jfp and ThP

Christian Hewitt (3):
      dt-bindings: net: bluetooth: Add device tree bindings for QCA9377
      Bluetooth: hci_qca: add compatible for QCA9377
      Bluetooth: hci_qca: allow max-speed to be set for QCA9377 devices

Hans de Goede (8):
      Bluetooth: btbcm: Drop upper nibble version check from btbcm_initialize()
      Bluetooth: btbcm: Move setting of USE_BDADDR_PROPERTY quirk to hci_bcm.c
      Bluetooth: btbcm: Fold Patch loading + applying into btbcm_initialize()
      Bluetooth: btbcm: Make btbcm_initialize() print local-name on re-init too
      Bluetooth: btbcm: Make btbcm_setup_patchram use btbcm_finalize
      Bluetooth: btbcm: Bail sooner from btbcm_initialize() when not loading fw
      Bluetooth: btbcm: Try multiple Patch filenames when loading the Patch firmware
      Bluetooth: btbcm: Add 2 missing models to subver tables

Hegde, Raghuram (1):
      Bluetooth: btusb: Add support for Intel Bluetooth Device Typhoon Peak (8087:0032)

Konstantin Forostyan (1):
      Bluetooth: L2CAP: Fix errors during L2CAP_CREDIT_BASED_CONNECTION_REQ (0x17)

Marcel Holtmann (7):
      Bluetooth: Add MGMT_EV_PHY_CONFIGURATION_CHANGED to supported list
      Bluetooth: Replace BT_DBG with bt_dev_dbg for management support
      Bluetooth: replace zero-length array with flexible-array member
      Bluetooth: Introduce HCI_MGMT_HDEV_OPTIONAL option
      Bluetooth: Replace BT_DBG with bt_dev_dbg for security manager support
      Bluetooth: Add support for experimental features configuration
      Bluetooth: Introduce debug feature when dynamic debug is disabled

Tedd Ho-Jeong An (1):
      Bluetooth: Fix advertising handle is set to 0

Vasily Khoruzhick (2):
      dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth
      Bluetooth: hci_h5: Add support for binding RTL8723BS with device tree

 .../devicetree/bindings/net/qualcomm-bluetooth.txt |   5 +
 .../devicetree/bindings/net/realtek-bluetooth.yaml |  54 +++
 drivers/bluetooth/btbcm.c                          | 139 ++++----
 drivers/bluetooth/btbcm.h                          |  10 +-
 drivers/bluetooth/btusb.c                          |  12 +-
 drivers/bluetooth/hci_bcm.c                        |  27 +-
 drivers/bluetooth/hci_h5.c                         |   2 +
 drivers/bluetooth/hci_qca.c                        |  17 +-
 include/net/bluetooth/bluetooth.h                  |  11 +
 include/net/bluetooth/hci.h                        |  10 +
 include/net/bluetooth/hci_core.h                   |   1 +
 include/net/bluetooth/mgmt.h                       |  69 ++--
 net/bluetooth/Kconfig                              |   7 +
 net/bluetooth/hci_event.c                          |   4 +-
 net/bluetooth/hci_request.c                        |   6 +-
 net/bluetooth/hci_sock.c                           |  12 +-
 net/bluetooth/l2cap_core.c                         |   4 +-
 net/bluetooth/lib.c                                |  33 ++
 net/bluetooth/mgmt.c                               | 364 ++++++++++++++-------
 net/bluetooth/smp.c                                |   8 +-
 20 files changed, 556 insertions(+), 239 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.yaml

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: pull request: bluetooth-next 2020-05-09

[Jakub Kicinski]

On Sat, 9 May 2020 21:49:28 +0300 Johan Hedberg wrote:
> Hi Dave,
> 
> Here's another set of Bluetooth patches for the 5.8 kernel:
> 
>  - Add support for Intel Typhoon Peak device (8087:0032)
>  - Add device tree bindings for Realtek RTL8723BS device
>  - Add device tree bindings for Qualcomm QCA9377 device
>  - Add support for experimental features configuration through mgmt
>  - Multiple fixes & cleanups to the btbcm driver
>  - Add support for LE scatternet topology for selected devices
>  - A few other smaller fixes & cleanups
> 
> Please let me know if there are any issues pulling. Thanks.

Is your tree immutable, is there a chance you could still get the missing sign-off?

Commit bf1f79470a62 ("Bluetooth: btusb: Add support for Intel Bluetooth Device Typhoon Peak (8087:0032)")
	author Signed-off-by missing
	author email:    raghuram.hegde@intel.com
	committer email: marcel@holtmann.org
	Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
	Signed-off-by: Tumkur Narayan, Chethan <chethan.tumkur.narayan@intel.com>
	Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Also, in the same patch:

---------------------------------------------------------------
0015-Bluetooth-btusb-Add-support-for-Intel-Bluetooth-Devi.patch
---------------------------------------------------------------
ERROR: code indent should use tabs where possible
#55: FILE: drivers/bluetooth/btusb.c:346:
+                                                     BTUSB_WIDEBAND_SPEECH},$

WARNING: please, no spaces at the start of a line
#55: FILE: drivers/bluetooth/btusb.c:346:
+                                                     BTUSB_WIDEBAND_SPEECH},$

WARNING: Missing Signed-off-by: line by nominal patch author '"Hegde, Raghuram" <raghuram.hegde@intel.com>'

total: 1 errors, 2 warnings, 0 checks, 8 lines checked


And:

------------------------------------------------------------
0016-dt-bindings-net-bluetooth-Add-rtl8723bs-bluetooth.patch
------------------------------------------------------------
WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)
#23: FILE: Documentation/devicetree/bindings/net/realtek-bluetooth.yaml:1:
+# SPDX-License-Identifier: GPL-2.0

total: 0 errors, 2 warnings, 0 checks, 54 lines checked

---------------------------------------------------------------
0026-Bluetooth-Introduce-debug-feature-when-dynamic-debug.patch
---------------------------------------------------------------
WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...
#99: FILE: net/bluetooth/lib.c:212:
+	printk(KERN_DEBUG pr_fmt("%pV"), &vaf);

WARNING: Missing a blank line after declarations
#135: FILE: net/bluetooth/mgmt.c:3740:
+		u32 flags = bt_dbg_get() ? BIT(0) : 0;
+		memcpy(rp->features[idx].uuid, debug_uuid, 16);

WARNING: Missing a blank line after declarations
#173: FILE: net/bluetooth/mgmt.c:3788:
+			bool changed = bt_dbg_get();
+			bt_dbg_set(false);

WARNING: 'Paramters' may be misspelled - perhaps 'Parameters'?
#197: FILE: net/bluetooth/mgmt.c:3812:
+		/* Paramters are limited to a single octet */

total: 0 errors, 5 warnings, 0 checks, 188 lines checked

Re: pull request: bluetooth-next 2020-05-09

[Marcel Holtmann]

Hi Jakub,

>> Here's another set of Bluetooth patches for the 5.8 kernel:
>> 
>> - Add support for Intel Typhoon Peak device (8087:0032)
>> - Add device tree bindings for Realtek RTL8723BS device
>> - Add device tree bindings for Qualcomm QCA9377 device
>> - Add support for experimental features configuration through mgmt
>> - Multiple fixes & cleanups to the btbcm driver
>> - Add support for LE scatternet topology for selected devices
>> - A few other smaller fixes & cleanups
>> 
>> Please let me know if there are any issues pulling. Thanks.
> 
> Is your tree immutable, is there a chance you could still get the missing sign-off?
> 
> Commit bf1f79470a62 ("Bluetooth: btusb: Add support for Intel Bluetooth Device Typhoon Peak (8087:0032)")
> 	author Signed-off-by missing
> 	author email:    raghuram.hegde@intel.com
> 	committer email: marcel@holtmann.org
> 	Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> 	Signed-off-by: Tumkur Narayan, Chethan <chethan.tumkur.narayan@intel.com>
> 	Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> 
> Also, in the same patch:
> 
> ---------------------------------------------------------------
> 0015-Bluetooth-btusb-Add-support-for-Intel-Bluetooth-Devi.patch
> ---------------------------------------------------------------
> ERROR: code indent should use tabs where possible
> #55: FILE: drivers/bluetooth/btusb.c:346:
> +                                                     BTUSB_WIDEBAND_SPEECH},$
> 
> WARNING: please, no spaces at the start of a line
> #55: FILE: drivers/bluetooth/btusb.c:346:
> +                                                     BTUSB_WIDEBAND_SPEECH},$
> 
> WARNING: Missing Signed-off-by: line by nominal patch author '"Hegde, Raghuram" <raghuram.hegde@intel.com>'
> 
> total: 1 errors, 2 warnings, 0 checks, 8 lines checked

I took this patch out. They should fix it up and re-submit it.

> 
> 
> And:
> 
> ------------------------------------------------------------
> 0016-dt-bindings-net-bluetooth-Add-rtl8723bs-bluetooth.patch
> ------------------------------------------------------------
> WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)
> #23: FILE: Documentation/devicetree/bindings/net/realtek-bluetooth.yaml:1:
> +# SPDX-License-Identifier: GPL-2.0
> 
> total: 0 errors, 2 warnings, 0 checks, 54 lines checked

I try to get this fixed, but it might have to come in a subsequent pull request.

> 
> ---------------------------------------------------------------
> 0026-Bluetooth-Introduce-debug-feature-when-dynamic-debug.patch
> ---------------------------------------------------------------
> WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...
> #99: FILE: net/bluetooth/lib.c:212:
> +	printk(KERN_DEBUG pr_fmt("%pV"), &vaf);

This one is on purpose and has to be printk.

> WARNING: Missing a blank line after declarations
> #135: FILE: net/bluetooth/mgmt.c:3740:
> +		u32 flags = bt_dbg_get() ? BIT(0) : 0;
> +		memcpy(rp->features[idx].uuid, debug_uuid, 16);
> 
> WARNING: Missing a blank line after declarations
> #173: FILE: net/bluetooth/mgmt.c:3788:
> +			bool changed = bt_dbg_get();
> +			bt_dbg_set(false);

These two were on purpose, but while at it, I fixed them up.

> WARNING: 'Paramters' may be misspelled - perhaps 'Parameters'?
> #197: FILE: net/bluetooth/mgmt.c:3812:
> +		/* Paramters are limited to a single octet */

This was a dumb spelling mistake and I fixed it up.

Thanks for checking everything. I think Johan will just send a new pull request.

Regards

Marcel