[PATCH v3] net: sched: export __netdev_watchdog_up()

[PATCH v3] net: sched: export __netdev_watchdog_up()

[Valentin Longchamp]

Since the quiesce/activate rework, __netdev_watchdog_up() is directly
called in the ucc_geth driver.

Unfortunately, this function is not available for modules and thus
ucc_geth cannot be built as a module anymore. Fix it by exporting
__netdev_watchdog_up().

Since the commit introducing the regression was backported to stable
branches, this one should ideally be as well.

Fixes: 79dde73cf9bc ("net/ethernet/freescale: rework quiesce/activate for ucc_geth")
Cc: <stable@vger.kernel.org>
Signed-off-by: Valentin Longchamp <valentin@longchamp.me>
---
 net/sched/sch_generic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index b19a0021a0bd..265a61d011df 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -464,6 +464,7 @@ void __netdev_watchdog_up(struct net_device *dev)
 			dev_hold(dev);
 	}
 }
+EXPORT_SYMBOL_GPL(__netdev_watchdog_up);
 
 static void dev_watchdog_up(struct net_device *dev)
 {
-- 
2.25.1

Re: [PATCH v3] net: sched: export __netdev_watchdog_up()

[David Miller]

From: Valentin Longchamp <valentin@longchamp.me>
Date: Tue,  9 Jun 2020 22:11:54 +0200

> Since the quiesce/activate rework, __netdev_watchdog_up() is directly
> called in the ucc_geth driver.
> 
> Unfortunately, this function is not available for modules and thus
> ucc_geth cannot be built as a module anymore. Fix it by exporting
> __netdev_watchdog_up().
> 
> Since the commit introducing the regression was backported to stable
> branches, this one should ideally be as well.
> 
> Fixes: 79dde73cf9bc ("net/ethernet/freescale: rework quiesce/activate for ucc_geth")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Valentin Longchamp <valentin@longchamp.me>

Applied and queued up for -stable, please don't CC: stable for networking changes
in the future, thank you.