From: Sabrina Dubroca <sd@queasysnail.net>
To: Xin Long <lucien.xin@gmail.com>
Cc: netdev@vger.kernel.org,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm_tunnel
Date: Mon, 22 Jun 2020 15:16:50 +0200 [thread overview]
Message-ID: <20200622131650.GD2557669@bistromath.localdomain> (raw)
In-Reply-To: <5a63a0c47cc71476786873cbd32db8db3c0f7d1e.1592328814.git.lucien.xin@gmail.com>
2020-06-17, 01:36:27 +0800, Xin Long wrote:
> @@ -231,6 +255,7 @@ static int __init tunnel4_init(void)
> goto err;
> }
> #endif
> + xfrm_input_register_afinfo(&tunnel4_input_afinfo);
This can fail. Shouldn't you handle that error?
> return 0;
>
> err:
--
Sabrina
next prev parent reply other threads:[~2020-06-22 13:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 17:36 [PATCH ipsec-next 00/10] xfrm: support ipip and ipv6 tunnels in vti and xfrmi Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 01/10] xfrm: add is_ipip to struct xfrm_input_afinfo Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 02/10] tunnel4: add cb_handler to struct xfrm_tunnel Xin Long
2020-06-17 16:19 ` Jakub Kicinski
2020-06-22 8:29 ` Xin Long
2020-06-22 13:16 ` Sabrina Dubroca [this message]
2020-06-22 17:18 ` Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 03/10] tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels Xin Long
2020-06-17 16:19 ` Jakub Kicinski
2020-06-22 8:30 ` Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 04/10] ip_vti: support IPIP tunnel processing with .cb_handler Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 05/10] ip_vti: support IPIP6 tunnel processing Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 06/10] ip6_vti: support IP6IP6 tunnel processing with .cb_handler Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 07/10] ip6_vti: support IP6IP tunnel processing Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 08/10] ipcomp: assign if_id to child tunnel from parent tunnel Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 09/10] xfrm: interface: support IP6IP6 and IP6IP tunnels processing with .cb_handler Xin Long
2020-06-16 17:36 ` [PATCH ipsec-next 10/10] xfrm: interface: support IPIP and IPIP6 " Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622131650.GD2557669@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox