* [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range
@ 2020-07-20 2:53 Wang Hai
2020-07-20 3:15 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Wang Hai @ 2020-07-20 2:53 UTC (permalink / raw)
To: joe, gtzalik, saeedb, zorik, davem, kuba, sameehj; +Cc: netdev, linux-kernel
Fix sparse build warning:
drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
Using plain integer as NULL pointer
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Suggested-by: Joe Perches <joe@perches.com>
Acked-by: Shay Agroskin <shayagr@amazon.com>
---
v1->v2:
Improve code readability based on Joe Perches's suggestion
drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 91be3ffa1c5c..470d8f38b824 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -2190,11 +2190,10 @@ static void ena_del_napi_in_range(struct ena_adapter *adapter,
static void ena_init_napi_in_range(struct ena_adapter *adapter,
int first_index, int count)
{
- struct ena_napi *napi = {0};
int i;
for (i = first_index; i < first_index + count; i++) {
- napi = &adapter->ena_napi[i];
+ struct ena_napi *napi = &adapter->ena_napi[i];
netif_napi_add(adapter->netdev,
&adapter->ena_napi[i].napi,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range
2020-07-20 2:53 [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range Wang Hai
@ 2020-07-20 3:15 ` Joe Perches
2020-07-20 6:38 ` Shay Agroskin
2020-07-20 7:08 ` wanghai (M)
0 siblings, 2 replies; 4+ messages in thread
From: Joe Perches @ 2020-07-20 3:15 UTC (permalink / raw)
To: Wang Hai, gtzalik, saeedb, zorik, davem, kuba, sameehj
Cc: netdev, linux-kernel
On Mon, 2020-07-20 at 10:53 +0800, Wang Hai wrote:
> Fix sparse build warning:
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
> Using plain integer as NULL pointer
[]
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
[]
> @@ -2190,11 +2190,10 @@ static void ena_del_napi_in_range(struct ena_adapter *adapter,
> static void ena_init_napi_in_range(struct ena_adapter *adapter,
> int first_index, int count)
> {
> - struct ena_napi *napi = {0};
> int i;
>
> for (i = first_index; i < first_index + count; i++) {
> - napi = &adapter->ena_napi[i];
> + struct ena_napi *napi = &adapter->ena_napi[i];
>
> netif_napi_add(adapter->netdev,
> &adapter->ena_napi[i].napi,
Another possible change is to this statement:
netif_napi_add(adapter->netdev,
&napi->napi,
etc...);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range
2020-07-20 3:15 ` Joe Perches
@ 2020-07-20 6:38 ` Shay Agroskin
2020-07-20 7:08 ` wanghai (M)
1 sibling, 0 replies; 4+ messages in thread
From: Shay Agroskin @ 2020-07-20 6:38 UTC (permalink / raw)
To: Joe Perches
Cc: Wang Hai, gtzalik, saeedb, zorik, davem, kuba, sameehj, netdev,
linux-kernel
Joe Perches <joe@perches.com> writes:
> On Mon, 2020-07-20 at 10:53 +0800, Wang Hai wrote:
>> Fix sparse build warning:
>>
>> drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
>> Using plain integer as NULL pointer
> []
>> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
>> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> []
>> @@ -2190,11 +2190,10 @@ static void
>> ena_del_napi_in_range(struct ena_adapter *adapter,
>> static void ena_init_napi_in_range(struct ena_adapter
>> *adapter,
>> int first_index, int count)
>> {
>> - struct ena_napi *napi = {0};
>> int i;
>>
>> for (i = first_index; i < first_index + count; i++) {
>> - napi = &adapter->ena_napi[i];
>> + struct ena_napi *napi = &adapter->ena_napi[i];
>>
>> netif_napi_add(adapter->netdev,
>> &adapter->ena_napi[i].napi,
>
> Another possible change is to this statement:
>
> netif_napi_add(adapter->netdev,
> &napi->napi,
> etc...);
Yup, missed that myself. Wang, if you don't mind please apply
Joe's change as well.
Thanks, Shay
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range
2020-07-20 3:15 ` Joe Perches
2020-07-20 6:38 ` Shay Agroskin
@ 2020-07-20 7:08 ` wanghai (M)
1 sibling, 0 replies; 4+ messages in thread
From: wanghai (M) @ 2020-07-20 7:08 UTC (permalink / raw)
To: Joe Perches, gtzalik, saeedb, zorik, davem, kuba, sameehj
Cc: netdev, linux-kernel
在 2020/7/20 11:15, Joe Perches 写道:
> On Mon, 2020-07-20 at 10:53 +0800, Wang Hai wrote:
>> Fix sparse build warning:
>>
>> drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
>> Using plain integer as NULL pointer
> []
>> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> []
>> @@ -2190,11 +2190,10 @@ static void ena_del_napi_in_range(struct ena_adapter *adapter,
>> static void ena_init_napi_in_range(struct ena_adapter *adapter,
>> int first_index, int count)
>> {
>> - struct ena_napi *napi = {0};
>> int i;
>>
>> for (i = first_index; i < first_index + count; i++) {
>> - napi = &adapter->ena_napi[i];
>> + struct ena_napi *napi = &adapter->ena_napi[i];
>>
>> netif_napi_add(adapter->netdev,
>> &adapter->ena_napi[i].napi,
> Another possible change is to this statement:
>
> netif_napi_add(adapter->netdev,
> &napi->napi,
> etc...);
>
Good catch. I'll add this change, Thanks.
>
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-20 7:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-20 2:53 [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range Wang Hai
2020-07-20 3:15 ` Joe Perches
2020-07-20 6:38 ` Shay Agroskin
2020-07-20 7:08 ` wanghai (M)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox