From: Vladimir Oltean <olteanv@gmail.com>
To: "Gaube, Marvin (THSE-TL1)" <Marvin.Gaube@tesat.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
edumazet@google.com
Subject: Re: PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge
Date: Tue, 4 Aug 2020 17:27:08 +0300 [thread overview]
Message-ID: <20200804142708.zjos3b6jvqjj7uas@skbuf> (raw)
In-Reply-To: <020a80686edc48d5810e1dbf884ae497@BK99MAIL02.bk.local>
On Tue, Aug 04, 2020 at 02:14:33PM +0000, Gaube, Marvin (THSE-TL1) wrote:
> Hello,
> I looked into it deeper, the driver does rxvlan offloading.
> By disabling it manually trough ethtool, the behavior becomes as
> expected.
>
> I've taken "net: dsa: sja1105: disable rxvlan offload for the DSA
> master" from
> (https://lore.kernel.org/netdev/20200512234921.25460-1-olteanv@gmail.com/)
> and also applied it to the KSZ9477-Driver, which fixes the problem.
> It's probably a workaround, but fixes the VLAN behavior for now. I
> would suggest also applying "ds->disable_master_rxvlan = true;" to
> KSZ9477 after the mentioned patch is merged.
>
> Best Regards
> Marvin Gaube
>
And I wanted to suggest that, but it seemed too freaky to be what's
going on.... But since ksz9477 uses a tail tag, it makes perfect sense.
My patch is in limbo because Eric, who started zeroing the skb offloaded
VLAN data in the first place, hasn't said anything.
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-08-04 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 6:05 PROBLEM: (DSA/Microchip): 802.1Q-Header lost on KSZ9477-DSA ingress without bridge Gaube, Marvin (THSE-TL1)
2020-07-29 13:48 ` Florian Fainelli
2020-07-29 14:49 ` AW: " Gaube, Marvin (THSE-TL1)
2020-07-29 15:02 ` Florian Fainelli
2020-07-30 9:34 ` AW: " Gaube, Marvin (THSE-TL1)
2020-08-04 14:14 ` Gaube, Marvin (THSE-TL1)
2020-08-04 14:27 ` Vladimir Oltean [this message]
2020-08-04 14:54 ` Eric Dumazet
2020-08-04 19:29 ` Vladimir Oltean
2020-08-04 19:40 ` Eric Dumazet
2020-08-04 19:43 ` Vladimir Oltean
2020-08-04 20:36 ` Eric Dumazet
2020-08-04 21:24 ` Vladimir Oltean
2020-08-04 22:29 ` Eric Dumazet
2020-08-04 22:39 ` Vladimir Oltean
2020-08-04 22:44 ` Vladimir Oltean
2020-08-04 23:02 ` Steinar H. Gunderson
2020-08-04 15:51 ` AW: AW: " Florian Fainelli
2020-08-04 19:54 ` Vladimir Oltean
2020-08-04 20:20 ` Florian Fainelli
2020-08-05 5:45 ` AW: " Gaube, Marvin (THSE-TL1)
2020-09-15 0:02 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804142708.zjos3b6jvqjj7uas@skbuf \
--to=olteanv@gmail.com \
--cc=Marvin.Gaube@tesat.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox