* [PATCH] dpaa_eth: enable NETIF_MSG_HW by default
@ 2020-10-08 12:03 Vladimir Oltean
2020-10-08 12:11 ` Vladimir Oltean
2020-10-08 14:37 ` Madalin Bucur (OSS)
0 siblings, 2 replies; 4+ messages in thread
From: Vladimir Oltean @ 2020-10-08 12:03 UTC (permalink / raw)
To: davem; +Cc: netdev, madalin.bucur, camelia.groza, Maxim Kochetkov
From: Maxim Kochetkov <fido_max@inbox.ru>
When packets are received on the error queue, this function under
net_ratelimit():
netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
does not get printed. Instead we only see:
[ 3658.845592] net_ratelimit: 244 callbacks suppressed
[ 3663.969535] net_ratelimit: 230 callbacks suppressed
[ 3669.085478] net_ratelimit: 228 callbacks suppressed
Enabling NETIF_MSG_HW fixes this issue, and we can see some information
about the frame descriptors of packets.
Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index fdff3b4723ba..06cc863f4dd6 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -87,7 +87,7 @@ MODULE_PARM_DESC(tx_timeout, "The Tx timeout in ms");
#define DPAA_MSG_DEFAULT (NETIF_MSG_DRV | NETIF_MSG_PROBE | \
NETIF_MSG_LINK | NETIF_MSG_IFUP | \
- NETIF_MSG_IFDOWN)
+ NETIF_MSG_IFDOWN | NETIF_MSG_HW)
#define DPAA_INGRESS_CS_THRESHOLD 0x10000000
/* Ingress congestion threshold on FMan ports
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default
2020-10-08 12:03 [PATCH] dpaa_eth: enable NETIF_MSG_HW by default Vladimir Oltean
@ 2020-10-08 12:11 ` Vladimir Oltean
2020-10-08 14:37 ` Madalin Bucur (OSS)
1 sibling, 0 replies; 4+ messages in thread
From: Vladimir Oltean @ 2020-10-08 12:11 UTC (permalink / raw)
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Madalin Bucur (OSS),
Camelia Alexandra Groza, Maxim Kochetkov
On Thu, Oct 08, 2020 at 03:03:12PM +0300, Vladimir Oltean wrote:
> From: Maxim Kochetkov <fido_max@inbox.ru>
>
> When packets are received on the error queue, this function under
> net_ratelimit():
>
> netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
>
> does not get printed. Instead we only see:
>
> [ 3658.845592] net_ratelimit: 244 callbacks suppressed
> [ 3663.969535] net_ratelimit: 230 callbacks suppressed
> [ 3669.085478] net_ratelimit: 228 callbacks suppressed
>
> Enabling NETIF_MSG_HW fixes this issue, and we can see some information
> about the frame descriptors of packets.
>
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
I'm sorry for failing to mention the target tree in the email subject.
This is directed towards net-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default
2020-10-08 12:03 [PATCH] dpaa_eth: enable NETIF_MSG_HW by default Vladimir Oltean
2020-10-08 12:11 ` Vladimir Oltean
@ 2020-10-08 14:37 ` Madalin Bucur (OSS)
2020-10-10 17:51 ` Jakub Kicinski
1 sibling, 1 reply; 4+ messages in thread
From: Madalin Bucur (OSS) @ 2020-10-08 14:37 UTC (permalink / raw)
To: Vladimir Oltean, davem@davemloft.net
Cc: netdev@vger.kernel.org, Madalin Bucur (OSS),
Camelia Alexandra Groza, Maxim Kochetkov
> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> To: davem@davemloft.net
> Subject: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default
>
> From: Maxim Kochetkov <fido_max@inbox.ru>
>
> When packets are received on the error queue, this function under
> net_ratelimit():
>
> netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
>
> does not get printed. Instead we only see:
>
> [ 3658.845592] net_ratelimit: 244 callbacks suppressed
> [ 3663.969535] net_ratelimit: 230 callbacks suppressed
> [ 3669.085478] net_ratelimit: 228 callbacks suppressed
>
> Enabling NETIF_MSG_HW fixes this issue, and we can see some information
> about the frame descriptors of packets.
>
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index fdff3b4723ba..06cc863f4dd6 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -87,7 +87,7 @@ MODULE_PARM_DESC(tx_timeout, "The Tx timeout in ms");
>
> #define DPAA_MSG_DEFAULT (NETIF_MSG_DRV | NETIF_MSG_PROBE | \
> NETIF_MSG_LINK | NETIF_MSG_IFUP | \
> - NETIF_MSG_IFDOWN)
> + NETIF_MSG_IFDOWN | NETIF_MSG_HW)
>
> #define DPAA_INGRESS_CS_THRESHOLD 0x10000000
> /* Ingress congestion threshold on FMan ports
> --
> 2.25.1
Reviewed-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default
2020-10-08 14:37 ` Madalin Bucur (OSS)
@ 2020-10-10 17:51 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-10-10 17:51 UTC (permalink / raw)
To: Madalin Bucur (OSS)
Cc: Vladimir Oltean, davem@davemloft.net, netdev@vger.kernel.org,
Camelia Alexandra Groza, Maxim Kochetkov
On Thu, 8 Oct 2020 14:37:44 +0000 Madalin Bucur (OSS) wrote:
> > From: Maxim Kochetkov <fido_max@inbox.ru>
> >
> > When packets are received on the error queue, this function under
> > net_ratelimit():
> >
> > netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
> >
> > does not get printed. Instead we only see:
> >
> > [ 3658.845592] net_ratelimit: 244 callbacks suppressed
> > [ 3663.969535] net_ratelimit: 230 callbacks suppressed
> > [ 3669.085478] net_ratelimit: 228 callbacks suppressed
> >
> > Enabling NETIF_MSG_HW fixes this issue, and we can see some information
> > about the frame descriptors of packets.
> >
> > Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Reviewed-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
Applied, thanks everyone!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-10 23:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-08 12:03 [PATCH] dpaa_eth: enable NETIF_MSG_HW by default Vladimir Oltean
2020-10-08 12:11 ` Vladimir Oltean
2020-10-08 14:37 ` Madalin Bucur (OSS)
2020-10-10 17:51 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox