* [PATCH v1] net: phy: micrel: fix interrupt handling
@ 2020-11-27 12:36 Oleksij Rempel
2020-11-27 14:45 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: Oleksij Rempel @ 2020-11-27 12:36 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit
Cc: Oleksij Rempel, David S. Miller, kernel, linux-kernel, netdev,
Philippe Schenker, Ioana Ciornei
After migration to the shared interrupt support, the KSZ8031 PHY with
enabled interrupt support was not able to notify about link status
change.
Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/phy/micrel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 97f08f20630b..54e0d75203da 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -207,7 +207,7 @@ static irqreturn_t kszphy_handle_interrupt(struct phy_device *phydev)
return IRQ_NONE;
}
- if ((irq_status & KSZPHY_INTCS_STATUS))
+ if (!(irq_status & KSZPHY_INTCS_STATUS))
return IRQ_NONE;
phy_trigger_machine(phydev);
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] net: phy: micrel: fix interrupt handling
2020-11-27 12:36 [PATCH v1] net: phy: micrel: fix interrupt handling Oleksij Rempel
@ 2020-11-27 14:45 ` Andrew Lunn
2020-11-27 15:11 ` Ioana Ciornei
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Lunn @ 2020-11-27 14:45 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Florian Fainelli, Heiner Kallweit, David S. Miller, kernel,
linux-kernel, netdev, Philippe Schenker, Ioana Ciornei
On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote:
> After migration to the shared interrupt support, the KSZ8031 PHY with
> enabled interrupt support was not able to notify about link status
> change.
>
> Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
I took a quick look at all the other patches like this. I did not spot
any other missing the !
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] net: phy: micrel: fix interrupt handling
2020-11-27 14:45 ` Andrew Lunn
@ 2020-11-27 15:11 ` Ioana Ciornei
2020-11-28 1:27 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Ioana Ciornei @ 2020-11-27 15:11 UTC (permalink / raw)
To: Andrew Lunn
Cc: Oleksij Rempel, Florian Fainelli, Heiner Kallweit,
David S. Miller, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Philippe Schenker
On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote:
> On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote:
> > After migration to the shared interrupt support, the KSZ8031 PHY with
> > enabled interrupt support was not able to notify about link status
> > change.
> >
> > Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> I took a quick look at all the other patches like this. I did not spot
> any other missing the !
>
> Andrew
Uhh, really sorry for this!
Thanks for double checking.
Ioana
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] net: phy: micrel: fix interrupt handling
2020-11-27 15:11 ` Ioana Ciornei
@ 2020-11-28 1:27 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-11-28 1:27 UTC (permalink / raw)
To: Ioana Ciornei
Cc: Andrew Lunn, Oleksij Rempel, Florian Fainelli, Heiner Kallweit,
David S. Miller, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Philippe Schenker
On Fri, 27 Nov 2020 15:11:08 +0000 Ioana Ciornei wrote:
> On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote:
> > On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote:
> > > After migration to the shared interrupt support, the KSZ8031 PHY with
> > > enabled interrupt support was not able to notify about link status
> > > change.
> > >
> > > Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> >
> > I took a quick look at all the other patches like this. I did not spot
> > any other missing the !
> >
> > Andrew
>
> Uhh, really sorry for this!
>
> Thanks for double checking.
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-28 2:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27 12:36 [PATCH v1] net: phy: micrel: fix interrupt handling Oleksij Rempel
2020-11-27 14:45 ` Andrew Lunn
2020-11-27 15:11 ` Ioana Ciornei
2020-11-28 1:27 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox