* [PATCH net v2] docs: net: fix documentation on .ndo_get_stats
@ 2021-01-05 1:22 Jakub Kicinski
2021-01-05 11:51 ` Vladimir Oltean
2021-01-06 0:42 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-01-05 1:22 UTC (permalink / raw)
To: davem; +Cc: netdev, olteanv, Jakub Kicinski
Fix calling context.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Documentation/networking/netdevices.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
index 5a85fcc80c76..e65665c5ab50 100644
--- a/Documentation/networking/netdevices.rst
+++ b/Documentation/networking/netdevices.rst
@@ -64,8 +64,8 @@ struct net_device synchronization rules
Context: process
ndo_get_stats:
- Synchronization: dev_base_lock rwlock.
- Context: nominally process, but don't sleep inside an rwlock
+ Synchronization: rtnl_lock() semaphore, dev_base_lock rwlock, or RCU.
+ Context: atomic (can't sleep under rwlock or RCU)
ndo_start_xmit:
Synchronization: __netif_tx_lock spinlock.
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] docs: net: fix documentation on .ndo_get_stats
2021-01-05 1:22 [PATCH net v2] docs: net: fix documentation on .ndo_get_stats Jakub Kicinski
@ 2021-01-05 11:51 ` Vladimir Oltean
2021-01-06 0:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2021-01-05 11:51 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev
On Mon, Jan 04, 2021 at 05:22:24PM -0800, Jakub Kicinski wrote:
> Fix calling context.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Documentation/networking/netdevices.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
> index 5a85fcc80c76..e65665c5ab50 100644
> --- a/Documentation/networking/netdevices.rst
> +++ b/Documentation/networking/netdevices.rst
> @@ -64,8 +64,8 @@ struct net_device synchronization rules
> Context: process
>
> ndo_get_stats:
> - Synchronization: dev_base_lock rwlock.
> - Context: nominally process, but don't sleep inside an rwlock
> + Synchronization: rtnl_lock() semaphore, dev_base_lock rwlock, or RCU.
> + Context: atomic (can't sleep under rwlock or RCU)
>
> ndo_start_xmit:
> Synchronization: __netif_tx_lock spinlock.
> --
> 2.26.2
>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] docs: net: fix documentation on .ndo_get_stats
2021-01-05 1:22 [PATCH net v2] docs: net: fix documentation on .ndo_get_stats Jakub Kicinski
2021-01-05 11:51 ` Vladimir Oltean
@ 2021-01-06 0:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2021-01-06 0:42 UTC (permalink / raw)
To: kuba; +Cc: netdev, olteanv
From: Jakub Kicinski <kuba@kernel.org>
Date: Mon, 4 Jan 2021 17:22:24 -0800
> Fix calling context.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-06 0:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-05 1:22 [PATCH net v2] docs: net: fix documentation on .ndo_get_stats Jakub Kicinski
2021-01-05 11:51 ` Vladimir Oltean
2021-01-06 0:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox