From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-imx@nxp.com, andrew@lunn.ch,
f.fainelli@gmail.com
Subject: [PATCH V3 2/6] net: stmmac: stop each tx channel independently
Date: Tue, 26 Jan 2021 19:58:50 +0800 [thread overview]
Message-ID: <20210126115854.2530-3-qiangqing.zhang@nxp.com> (raw)
In-Reply-To: <20210126115854.2530-1-qiangqing.zhang@nxp.com>
If clear GMAC_CONFIG_TE bit, it would stop all tx channels, but users
may only want to stop secific tx channel.
Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx")
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
index 0b4ee2dbb691..71e50751ef2d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
@@ -53,10 +53,6 @@ void dwmac4_dma_stop_tx(void __iomem *ioaddr, u32 chan)
value &= ~DMA_CONTROL_ST;
writel(value, ioaddr + DMA_CHAN_TX_CONTROL(chan));
-
- value = readl(ioaddr + GMAC_CONFIG);
- value &= ~GMAC_CONFIG_TE;
- writel(value, ioaddr + GMAC_CONFIG);
}
void dwmac4_dma_start_rx(void __iomem *ioaddr, u32 chan)
--
2.17.1
next prev parent reply other threads:[~2021-01-26 12:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 11:58 [PATCH V3 0/6] ethernet: fixes for stmmac driver Joakim Zhang
2021-01-26 11:58 ` [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp clock Joakim Zhang
2021-01-26 22:46 ` Willem de Bruijn
2021-01-27 1:30 ` Joakim Zhang
2021-01-27 1:33 ` Florian Fainelli
2021-01-27 1:49 ` Joakim Zhang
2021-01-26 11:58 ` Joakim Zhang [this message]
2021-01-26 23:09 ` [PATCH V3 2/6] net: stmmac: stop each tx channel independently Willem de Bruijn
2021-01-27 1:44 ` Joakim Zhang
2021-01-27 2:16 ` Willem de Bruijn
2021-01-26 11:58 ` [PATCH V3 3/6] net: stmmac: fix watchdog timeout during suspend/resume stress test Joakim Zhang
2021-01-26 11:58 ` [PATCH V3 4/6] net: stmmac: fix dma physical address of descriptor when display ring Joakim Zhang
2021-01-26 11:58 ` [PATCH V3 5/6] net: stmmac: fix wrongly set buffer2 valid when sph unsupport Joakim Zhang
2021-01-26 11:58 ` [PATCH V3 6/6] net: stmmac: re-init rx buffers when mac resume back Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126115854.2530-3-qiangqing.zhang@nxp.com \
--to=qiangqing.zhang@nxp.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox