From: Florian Fainelli <f.fainelli@gmail.com>
To: Joakim Zhang <qiangqing.zhang@nxp.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Network Development <netdev@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp clock
Date: Tue, 26 Jan 2021 17:33:28 -0800 [thread overview]
Message-ID: <e2f16f61-4f45-de76-65fc-272900cd14f7@gmail.com> (raw)
In-Reply-To: <DB8PR04MB67953865C100029E0088CE69E6BB0@DB8PR04MB6795.eurprd04.prod.outlook.com>
On 1/26/2021 5:30 PM, Joakim Zhang wrote:
>
>> -----Original Message-----
>> From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
>> Sent: 2021年1月27日 6:46
>> To: Joakim Zhang <qiangqing.zhang@nxp.com>
>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue
>> <alexandre.torgue@st.com>; Jose Abreu <joabreu@synopsys.com>; David
>> Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Network
>> Development <netdev@vger.kernel.org>; dl-linux-imx <linux-imx@nxp.com>;
>> Andrew Lunn <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>
>> Subject: Re: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp
>> clock
>>
>> On Tue, Jan 26, 2021 at 7:05 AM Joakim Zhang <qiangqing.zhang@nxp.com>
>> wrote:
>>>
>>> Remove redundant null check for ptp clock.
>>>
>>> Fixes: 1c35cc9cf6a0 ("net: stmmac: remove redundant null check before
>>> clk_disable_unprepare()")
>>
>> This does not look like a fix to that patch, but another instance of a cleanup.
>>
>> The patchset also does not explicitly target net (for fixes) or net-next (for new
>> improvements). I suppose this patch targets net-next.
>
> I forgot to explicitly target as net when format the patch set again. This could be a fix even original patch(1c35cc9cf6a0) doesn't break anything, but it didn't do all the work as commit message commit.
> This patch targets net or net-next, this matter doesn't seem to be that important. If it is necessary, I can repost it next time as a separate patch for net-next. Thanks.
Your patch series is titled "ethernet: fixes for stmmac driver" so we
sort of expect to find only bug fixes in there.
Given this patch has no dependency and does not create one on the
others, you should post that as a separate patch targeting the
'net-next' tree.
--
Florian
next prev parent reply other threads:[~2021-01-27 4:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 11:58 [PATCH V3 0/6] ethernet: fixes for stmmac driver Joakim Zhang
2021-01-26 11:58 ` [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp clock Joakim Zhang
2021-01-26 22:46 ` Willem de Bruijn
2021-01-27 1:30 ` Joakim Zhang
2021-01-27 1:33 ` Florian Fainelli [this message]
2021-01-27 1:49 ` Joakim Zhang
2021-01-26 11:58 ` [PATCH V3 2/6] net: stmmac: stop each tx channel independently Joakim Zhang
2021-01-26 23:09 ` Willem de Bruijn
2021-01-27 1:44 ` Joakim Zhang
2021-01-27 2:16 ` Willem de Bruijn
2021-01-26 11:58 ` [PATCH V3 3/6] net: stmmac: fix watchdog timeout during suspend/resume stress test Joakim Zhang
2021-01-26 11:58 ` [PATCH V3 4/6] net: stmmac: fix dma physical address of descriptor when display ring Joakim Zhang
2021-01-26 11:58 ` [PATCH V3 5/6] net: stmmac: fix wrongly set buffer2 valid when sph unsupport Joakim Zhang
2021-01-26 11:58 ` [PATCH V3 6/6] net: stmmac: re-init rx buffers when mac resume back Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2f16f61-4f45-de76-65fc-272900cd14f7@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox