* RE: net: phy: ti: implement generic .handle_interrupt() callback
@ 2021-02-23 17:44 Sven Schuchmann
2021-02-23 18:18 ` Ioana Ciornei
0 siblings, 1 reply; 2+ messages in thread
From: Sven Schuchmann @ 2021-02-23 17:44 UTC (permalink / raw)
To: Dan Murphy, ioana.ciornei@nxp.com, kuba@kernel.org
Cc: netdev@vger.kernel.org, Andrew Lunn, Heiner Kallweit,
linux@armlinux.org.uk, davem@davemloft.net
Hello all,
I am working with the DP83TC811R but for now on the 5.10 kernel.
I have seen this patch on the latest dev
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/phy/dp83tc811.c?h=v5.11&id=1d1ae3c6ca3ff49843d73852bb2a8153ce16f432
I did not test it yet, but I wonder about one thing:
What happens when there are 2 Flags set e.g.
in INT_STAT1 and one in INT_STAT2?
What I see from the code is that it would
only read (and acknowledge) the first one and
then quit out to trigger_machine.
Any thoughts about this?
Best Regards,
Sven
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: net: phy: ti: implement generic .handle_interrupt() callback
2021-02-23 17:44 net: phy: ti: implement generic .handle_interrupt() callback Sven Schuchmann
@ 2021-02-23 18:18 ` Ioana Ciornei
0 siblings, 0 replies; 2+ messages in thread
From: Ioana Ciornei @ 2021-02-23 18:18 UTC (permalink / raw)
To: Sven Schuchmann
Cc: Dan Murphy, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn,
Heiner Kallweit, linux@armlinux.org.uk, davem@davemloft.net
On Tue, Feb 23, 2021 at 05:44:57PM +0000, Sven Schuchmann wrote:
> Hello all,
>
> I am working with the DP83TC811R but for now on the 5.10 kernel.
> I have seen this patch on the latest dev
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/phy/dp83tc811.c?h=v5.11&id=1d1ae3c6ca3ff49843d73852bb2a8153ce16f432
>
> I did not test it yet, but I wonder about one thing:
> What happens when there are 2 Flags set e.g.
> in INT_STAT1 and one in INT_STAT2?
> What I see from the code is that it would
> only read (and acknowledge) the first one and
> then quit out to trigger_machine.
>
> Any thoughts about this?
>
Hi Sven,
Indeed, I didn't take into consideration the fact that all the status
registers should be acknowledged since multiple interrupt sources could
be asserted. This could really break a system with an edge-triggered
interrupt.
I'll send out a fixup patch.
Thanks!
Ioana
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-23 18:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-23 17:44 net: phy: ti: implement generic .handle_interrupt() callback Sven Schuchmann
2021-02-23 18:18 ` Ioana Ciornei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox