From: "Paul E. McKenney" <paulmck@kernel.org>
To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()
Date: Wed, 3 Mar 2021 09:53:38 -0800 [thread overview]
Message-ID: <20210303175338.GA15338@paulmck-ThinkPad-P72> (raw)
drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()
The following build error is emitted by rcutorture builds of v5.12-rc1:
drivers/net/phy/phy_device.c:293:12: warning: ‘mdio_bus_phy_resume’ defined but not used [-Wunused-function]
drivers/net/phy/phy_device.c:273:12: warning: ‘mdio_bus_phy_suspend’ defined but not used [-Wunused-function]
The problem is that these functions are only used by SIMPLE_DEV_PM_OPS(),
which creates a dev_pm_ops structure only in CONFIG_PM_SLEEP=y kernels.
Therefore, the mdio_bus_phy_suspend() and mdio_bus_phy_suspend() functions
will be used only in CONFIG_PM_SLEEP=y kernels. This commit therefore
wraps them in #ifdef CONFIG_PM_SLEEP.
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index ce49547..d6fb6e7 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -270,6 +270,8 @@ static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)
return !phydev->suspended;
}
+#ifdef CONFIG_PM_SLEEP
+
static int mdio_bus_phy_suspend(struct device *dev)
{
struct phy_device *phydev = to_phy_device(dev);
@@ -314,6 +316,8 @@ static int mdio_bus_phy_resume(struct device *dev)
return 0;
}
+#endif
+
static SIMPLE_DEV_PM_OPS(mdio_bus_phy_pm_ops, mdio_bus_phy_suspend,
mdio_bus_phy_resume);
#endif /* CONFIG_PM */
next reply other threads:[~2021-03-04 0:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 17:53 Paul E. McKenney [this message]
2021-03-03 18:04 ` [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() Russell King - ARM Linux admin
2021-03-03 18:15 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303175338.GA15338@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox