From: "Paul E. McKenney" <paulmck@kernel.org>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()
Date: Wed, 3 Mar 2021 10:15:35 -0800 [thread overview]
Message-ID: <20210303181535.GF2696@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20210303180422.GB1463@shell.armlinux.org.uk>
On Wed, Mar 03, 2021 at 06:04:22PM +0000, Russell King - ARM Linux admin wrote:
> On Wed, Mar 03, 2021 at 09:53:38AM -0800, Paul E. McKenney wrote:
> > drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()
> >
> > The following build error is emitted by rcutorture builds of v5.12-rc1:
> >
> > drivers/net/phy/phy_device.c:293:12: warning: ‘mdio_bus_phy_resume’ defined but not used [-Wunused-function]
> > drivers/net/phy/phy_device.c:273:12: warning: ‘mdio_bus_phy_suspend’ defined but not used [-Wunused-function]
> >
> > The problem is that these functions are only used by SIMPLE_DEV_PM_OPS(),
> > which creates a dev_pm_ops structure only in CONFIG_PM_SLEEP=y kernels.
> > Therefore, the mdio_bus_phy_suspend() and mdio_bus_phy_suspend() functions
> > will be used only in CONFIG_PM_SLEEP=y kernels. This commit therefore
> > wraps them in #ifdef CONFIG_PM_SLEEP.
>
> Arnd submitted a patch that Jakub has applied which fix these warnings
> in a slightly different way. Please see
> 20210225145748.404410-1-arnd@kernel.org
Works for me! When will this be hitting mainline?
Not a huge deal given that I can suppress the resulting rcutorture
failures by keeping a copy of either patch in -rcu, but I might not
be the only one hitting this.
Thanx, Paul
prev parent reply other threads:[~2021-03-04 0:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 17:53 [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() Paul E. McKenney
2021-03-03 18:04 ` Russell King - ARM Linux admin
2021-03-03 18:15 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303181535.GF2696@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox