[PATCH net-next] net: bridge: declare br_vlan_tunnel_lookup argument tunnel_id as __be64

[PATCH net-next] net: bridge: declare br_vlan_tunnel_lookup argument tunnel_id as __be64

[Vladimir Oltean]

From: Vladimir Oltean <vladimir.oltean@nxp.com>

The only caller of br_vlan_tunnel_lookup, br_handle_ingress_vlan_tunnel,
extracts the tunnel_id from struct ip_tunnel_info::struct ip_tunnel_key::
tun_id which is a __be64 value.

The exact endianness does not seem to matter, because the tunnel id is
just used as a lookup key for the VLAN group's tunnel hash table, and
the value is not interpreted directly per se. Moreover,
rhashtable_lookup_fast treats the key argument as a const void *.

Therefore, there is no functional change associated with this patch,
just one to silence "make W=1" builds.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/bridge/br_vlan_tunnel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_vlan_tunnel.c b/net/bridge/br_vlan_tunnel.c
index 169e005fbda2..0d3a8c01552e 100644
--- a/net/bridge/br_vlan_tunnel.c
+++ b/net/bridge/br_vlan_tunnel.c
@@ -35,7 +35,7 @@ static const struct rhashtable_params br_vlan_tunnel_rht_params = {
 };
 
 static struct net_bridge_vlan *br_vlan_tunnel_lookup(struct rhashtable *tbl,
-						     u64 tunnel_id)
+						     __be64 tunnel_id)
 {
 	return rhashtable_lookup_fast(tbl, &tunnel_id,
 				      br_vlan_tunnel_rht_params);
-- 
2.25.1

Re: [PATCH net-next] net: bridge: declare br_vlan_tunnel_lookup argument tunnel_id as __be64

[Nikolay Aleksandrov]

On 22/03/2021 12:38, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> The only caller of br_vlan_tunnel_lookup, br_handle_ingress_vlan_tunnel,
> extracts the tunnel_id from struct ip_tunnel_info::struct ip_tunnel_key::
> tun_id which is a __be64 value.
> 
> The exact endianness does not seem to matter, because the tunnel id is
> just used as a lookup key for the VLAN group's tunnel hash table, and
> the value is not interpreted directly per se. Moreover,
> rhashtable_lookup_fast treats the key argument as a const void *.
> 
> Therefore, there is no functional change associated with this patch,
> just one to silence "make W=1" builds.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  net/bridge/br_vlan_tunnel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bridge/br_vlan_tunnel.c b/net/bridge/br_vlan_tunnel.c
> index 169e005fbda2..0d3a8c01552e 100644
> --- a/net/bridge/br_vlan_tunnel.c
> +++ b/net/bridge/br_vlan_tunnel.c
> @@ -35,7 +35,7 @@ static const struct rhashtable_params br_vlan_tunnel_rht_params = {
>  };
>  
>  static struct net_bridge_vlan *br_vlan_tunnel_lookup(struct rhashtable *tbl,
> -						     u64 tunnel_id)
> +						     __be64 tunnel_id)
>  {
>  	return rhashtable_lookup_fast(tbl, &tunnel_id,
>  				      br_vlan_tunnel_rht_params);
> 

Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>

Re: [PATCH net-next] net: bridge: declare br_vlan_tunnel_lookup argument tunnel_id as __be64

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 22 Mar 2021 12:38:19 +0200 you wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> The only caller of br_vlan_tunnel_lookup, br_handle_ingress_vlan_tunnel,
> extracts the tunnel_id from struct ip_tunnel_info::struct ip_tunnel_key::
> tun_id which is a __be64 value.
> 
> The exact endianness does not seem to matter, because the tunnel id is
> just used as a lookup key for the VLAN group's tunnel hash table, and
> the value is not interpreted directly per se. Moreover,
> rhashtable_lookup_fast treats the key argument as a const void *.
> 
> [...]

Here is the summary with links:
  - [net-next] net: bridge: declare br_vlan_tunnel_lookup argument tunnel_id as __be64
    https://git.kernel.org/netdev/net-next/c/f5fcca89f59c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html