* [PATCH net-next] net: ax88796c: fix -Wpointer-bool-conversion warning
@ 2021-10-26 19:56 Arnd Bergmann
2021-10-26 19:59 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-10-26 19:56 UTC (permalink / raw)
To: Łukasz Stelmach, David S. Miller, Jakub Kicinski
Cc: Arnd Bergmann, Nathan Chancellor, Nick Desaulniers, netdev,
linux-kernel, llvm
From: Arnd Bergmann <arnd@arndb.de>
ax_local->phydev->advertising is an array, not a pointer, so
clang points out that checking for NULL is unnecessary:
drivers/net/ethernet/asix/ax88796c_main.c:851:24: error: address of array 'ax_local->phydev->advertising' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
if (ax_local->phydev->advertising &&
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ~~
Fixes: a97c69ba4f30 ("net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/asix/ax88796c_main.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethernet/asix/ax88796c_main.c
index cfc597f72e3d..846a04922561 100644
--- a/drivers/net/ethernet/asix/ax88796c_main.c
+++ b/drivers/net/ethernet/asix/ax88796c_main.c
@@ -848,11 +848,10 @@ ax88796c_open(struct net_device *ndev)
/* Setup flow-control configuration */
phy_support_asym_pause(ax_local->phydev);
- if (ax_local->phydev->advertising &&
- (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
- ax_local->phydev->advertising) ||
- linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
- ax_local->phydev->advertising)))
+ if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
+ ax_local->phydev->advertising) ||
+ linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
+ ax_local->phydev->advertising))
fc |= AX_FC_ANEG;
fc |= linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: ax88796c: fix -Wpointer-bool-conversion warning
2021-10-26 19:56 [PATCH net-next] net: ax88796c: fix -Wpointer-bool-conversion warning Arnd Bergmann
@ 2021-10-26 19:59 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-10-26 19:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Łukasz Stelmach, David S. Miller, Arnd Bergmann,
Nathan Chancellor, Nick Desaulniers, netdev, linux-kernel, llvm
On Tue, 26 Oct 2021 21:56:39 +0200 Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> ax_local->phydev->advertising is an array, not a pointer, so
> clang points out that checking for NULL is unnecessary:
>
> drivers/net/ethernet/asix/ax88796c_main.c:851:24: error: address of array 'ax_local->phydev->advertising' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
> if (ax_local->phydev->advertising &&
> ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ~~
>
> Fixes: a97c69ba4f30 ("net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/asix/ax88796c_main.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethernet/asix/ax88796c_main.c
> index cfc597f72e3d..846a04922561 100644
> --- a/drivers/net/ethernet/asix/ax88796c_main.c
> +++ b/drivers/net/ethernet/asix/ax88796c_main.c
> @@ -848,11 +848,10 @@ ax88796c_open(struct net_device *ndev)
> /* Setup flow-control configuration */
> phy_support_asym_pause(ax_local->phydev);
>
> - if (ax_local->phydev->advertising &&
> - (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
> - ax_local->phydev->advertising) ||
> - linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
> - ax_local->phydev->advertising)))
> + if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
> + ax_local->phydev->advertising) ||
> + linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
> + ax_local->phydev->advertising))
> fc |= AX_FC_ANEG;
>
> fc |= linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
Same as 971f5c4079ed46a131ad3ac6e684ed056a7777da in net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-26 19:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 19:56 [PATCH net-next] net: ax88796c: fix -Wpointer-bool-conversion warning Arnd Bergmann
2021-10-26 19:59 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox