* [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH
@ 2021-11-17 18:05 Maxim Petrov
2021-11-17 19:12 ` Stephen Hemminger
2021-11-17 22:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Maxim Petrov @ 2021-11-17 18:05 UTC (permalink / raw)
To: netdev; +Cc: mmrmaximuzz, Stephen Hemminger, David Miller
Fix the wild bracket in the if clause leading to the error in the condition.
Signed-off-by: Maxim Petrov <mmrmaximuzz@gmail.com>
---
tc/m_vlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tc/m_vlan.c b/tc/m_vlan.c
index 221083df..1b2b1d51 100644
--- a/tc/m_vlan.c
+++ b/tc/m_vlan.c
@@ -279,8 +279,8 @@ static int print_vlan(struct action_util *au, FILE *f, struct rtattr *arg)
ETH_ALEN, 0, b1, sizeof(b1));
print_string(PRINT_ANY, "dst_mac", " dst_mac %s", b1);
}
- if (tb[TCA_VLAN_PUSH_ETH_SRC &&
- RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN]) {
+ if (tb[TCA_VLAN_PUSH_ETH_SRC] &&
+ RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN) {
ll_addr_n2a(RTA_DATA(tb[TCA_VLAN_PUSH_ETH_SRC]),
ETH_ALEN, 0, b1, sizeof(b1));
print_string(PRINT_ANY, "src_mac", " src_mac %s", b1);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH
2021-11-17 18:05 [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH Maxim Petrov
@ 2021-11-17 19:12 ` Stephen Hemminger
2021-11-17 22:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2021-11-17 19:12 UTC (permalink / raw)
To: Maxim Petrov; +Cc: netdev, David Miller, gnault
On Wed, 17 Nov 2021 21:05:33 +0300
Maxim Petrov <mmrmaximuzz@gmail.com> wrote:
> Fix the wild bracket in the if clause leading to the error in the condition.
>
> Signed-off-by: Maxim Petrov <mmrmaximuzz@gmail.com>
> ---
> tc/m_vlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tc/m_vlan.c b/tc/m_vlan.c
> index 221083df..1b2b1d51 100644
> --- a/tc/m_vlan.c
> +++ b/tc/m_vlan.c
> @@ -279,8 +279,8 @@ static int print_vlan(struct action_util *au, FILE *f, struct rtattr *arg)
> ETH_ALEN, 0, b1, sizeof(b1));
> print_string(PRINT_ANY, "dst_mac", " dst_mac %s", b1);
> }
> - if (tb[TCA_VLAN_PUSH_ETH_SRC &&
> - RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN]) {
> + if (tb[TCA_VLAN_PUSH_ETH_SRC] &&
> + RTA_PAYLOAD(tb[TCA_VLAN_PUSH_ETH_SRC]) == ETH_ALEN) {
> ll_addr_n2a(RTA_DATA(tb[TCA_VLAN_PUSH_ETH_SRC]),
> ETH_ALEN, 0, b1, sizeof(b1));
> print_string(PRINT_ANY, "src_mac", " src_mac %s", b1);
Fixes: d61167dd88b4 ("m_vlan: add pop_eth and push_eth actions")
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH
2021-11-17 18:05 [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH Maxim Petrov
2021-11-17 19:12 ` Stephen Hemminger
@ 2021-11-17 22:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-17 22:00 UTC (permalink / raw)
To: Maxim Petrov; +Cc: netdev, stephen, davem
Hello:
This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:
On Wed, 17 Nov 2021 21:05:33 +0300 you wrote:
> Fix the wild bracket in the if clause leading to the error in the condition.
>
> Signed-off-by: Maxim Petrov <mmrmaximuzz@gmail.com>
> ---
> tc/m_vlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=0e949725908b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-17 22:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-17 18:05 [PATCH iproute2] tc/m_vlan: fix print_vlan() conditional on TCA_VLAN_ACT_PUSH_ETH Maxim Petrov
2021-11-17 19:12 ` Stephen Hemminger
2021-11-17 22:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox