From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Po Liu <po.liu@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Antoine Tenart <atenart@kernel.org>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
"Y.B. Lu" <yangbo.lu@nxp.com>, Rui Sousa <rui.sousa@nxp.com>,
Richard Cochran <richardcochran@gmail.com>,
"Allan W . Nielsen" <allan.nielsen@microchip.com>
Subject: Re: [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches
Date: Thu, 25 Nov 2021 23:45:21 +0000 [thread overview]
Message-ID: <20211125234520.2h6vtwar4hkb2knd@skbuf> (raw)
In-Reply-To: <20211125232118.2644060-1-vladimir.oltean@nxp.com>
On Fri, Nov 26, 2021 at 01:21:14AM +0200, Vladimir Oltean wrote:
> Po Liu reported recently that timestamping PTP over IPv4 is broken using
> the felix driver on NXP LS1028A. This has been known for a while, of
> course, since it has always been broken. The reason is because IP PTP
> packets are currently treated as unknown IP multicast, which is not
> flooded to the CPU port in the ocelot driver design, so packets don't
> reach the ptp4l program.
>
> The series solves the problem by installing packet traps per port when
> the timestamping ioctl is called, depending on the RX filter selected
> (L2, L4 or both).
>
> Vladimir Oltean (4):
> net: mscc: ocelot: don't downgrade timestamping RX filters in
> SIOCSHWTSTAMP
> net: mscc: ocelot: create a function that replaces an existing VCAP
> filter
> net: ptp: add a definition for the UDP port for IEEE 1588 general
> messages
> net: mscc: ocelot: set up traps for PTP packets
>
> drivers/net/ethernet/mscc/ocelot.c | 247 +++++++++++++++++++++++-
> drivers/net/ethernet/mscc/ocelot_vcap.c | 16 ++
> include/linux/ptp_classify.h | 1 +
> include/soc/mscc/ocelot_vcap.h | 2 +
> 4 files changed, 259 insertions(+), 7 deletions(-)
>
> --
> 2.25.1
>
I don't know why I targeted these patches to "net-next". Habit I guess.
Nonetheless, they apply equally well to "net", can they be considered
for merging there without me resending?
next prev parent reply other threads:[~2021-11-25 23:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 23:21 [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 1/4] net: mscc: ocelot: don't downgrade timestamping RX filters in SIOCSHWTSTAMP Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 2/4] net: mscc: ocelot: create a function that replaces an existing VCAP filter Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 3/4] net: ptp: add a definition for the UDP port for IEEE 1588 general messages Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 4/4] net: mscc: ocelot: set up traps for PTP packets Vladimir Oltean
2021-11-26 16:58 ` Richard Cochran
2021-11-26 17:01 ` Vladimir Oltean
2021-11-26 17:08 ` Richard Cochran
2021-11-26 17:11 ` Vladimir Oltean
2021-12-03 8:27 ` Kurt Kanzenbach
2021-11-25 23:45 ` Vladimir Oltean [this message]
2021-11-26 3:01 ` [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches Jakub Kicinski
2021-11-26 9:55 ` Vladimir Oltean
2021-11-26 18:35 ` Jakub Kicinski
2021-11-26 19:38 ` Vladimir Oltean
2021-11-26 19:55 ` Jakub Kicinski
2021-11-26 16:44 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211125234520.2h6vtwar4hkb2knd@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=richardcochran@gmail.com \
--cc=rui.sousa@nxp.com \
--cc=vivien.didelot@gmail.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox