public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Po Liu <po.liu@nxp.com>, "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Antoine Tenart <atenart@kernel.org>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
	"Y.B. Lu" <yangbo.lu@nxp.com>, Rui Sousa <rui.sousa@nxp.com>,
	"Allan W . Nielsen" <allan.nielsen@microchip.com>
Subject: Re: [PATCH net-next 4/4] net: mscc: ocelot: set up traps for PTP packets
Date: Fri, 26 Nov 2021 17:01:13 +0000	[thread overview]
Message-ID: <20211126170112.cw53nmeb6usv63bl@skbuf> (raw)
In-Reply-To: <20211126165847.GD27081@hoboy.vegasvil.org>

On Fri, Nov 26, 2021 at 08:58:47AM -0800, Richard Cochran wrote:
> On Fri, Nov 26, 2021 at 01:21:18AM +0200, Vladimir Oltean wrote:
> 
> > So PTP over L2 barely works, in the sense that PTP packets reach the CPU
> > port, but they reach it via flooding, and therefore reach lots of other
> > unwanted destinations too. But PTP over IPv4/IPv6 does not work at all.
> > This is because the Ocelot switch have ...
> 
> Not that the details are same, but I'd like to report that the Marvell
> switches (or driver or kernel) also have issues with PTP over UDP/IPv4.
> 
> When configured with separate interfaces, not in a bridge, you can run
> ptp4l as a UDP/IPv4 Boundary Clock, and it works fine.
> 
> When configured as a bridge, and running ptp4l as a UDP/IPv4
> Transparent Clock, it doesn't work.  It has been a while, and I don't
> have the HW any more, but I don't recall the exact behavior.  I think
> the switch did not treat the Event frames as switch management frames.
> 
> (BTW, running ptp4l TC over Layer-2 worked just fine with the switch
> configured as a bridge.)
> 
> Just saying, in case somebody with such a switch would like to try and
> fix the driver by adding special forwarding rules for the IPv4/6
> multicast addresses.

This, to me, sounds more like the bridge trapping the packets on br0
instead of letting them flow on the port netdevices, which is solved by
some netfilter rules? Or is it really a driver/hardware issue?

https://lore.kernel.org/netdev/20211116102138.26vkpeh23el6akya@skbuf/

  reply	other threads:[~2021-11-26 17:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 23:21 [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 1/4] net: mscc: ocelot: don't downgrade timestamping RX filters in SIOCSHWTSTAMP Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 2/4] net: mscc: ocelot: create a function that replaces an existing VCAP filter Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 3/4] net: ptp: add a definition for the UDP port for IEEE 1588 general messages Vladimir Oltean
2021-11-25 23:21 ` [PATCH net-next 4/4] net: mscc: ocelot: set up traps for PTP packets Vladimir Oltean
2021-11-26 16:58   ` Richard Cochran
2021-11-26 17:01     ` Vladimir Oltean [this message]
2021-11-26 17:08       ` Richard Cochran
2021-11-26 17:11         ` Vladimir Oltean
2021-12-03  8:27         ` Kurt Kanzenbach
2021-11-25 23:45 ` [PATCH net-next 0/4] Fix broken PTP over IP on Ocelot switches Vladimir Oltean
2021-11-26  3:01   ` Jakub Kicinski
2021-11-26  9:55     ` Vladimir Oltean
2021-11-26 18:35       ` Jakub Kicinski
2021-11-26 19:38         ` Vladimir Oltean
2021-11-26 19:55           ` Jakub Kicinski
2021-11-26 16:44 ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211126170112.cw53nmeb6usv63bl@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=allan.nielsen@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=po.liu@nxp.com \
    --cc=richardcochran@gmail.com \
    --cc=rui.sousa@nxp.com \
    --cc=vivien.didelot@gmail.com \
    --cc=xiaoliang.yang_1@nxp.com \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox