From: Michal Kubecek <mkubecek@suse.cz>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ido Schimmel <idosch@idosch.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
michel@fb.com, dcavalca@fb.com
Subject: Re: ethtool 5.16 release / ethtool -m bug fix
Date: Wed, 19 Jan 2022 00:14:23 +0100 [thread overview]
Message-ID: <20220118231423.aa66a42vso3hvobp@lion.mk-sys.cz> (raw)
In-Reply-To: <20220118145159.631fd6ed@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On Tue, Jan 18, 2022 at 02:51:59PM -0800, Jakub Kicinski wrote:
> Hi Michal!
>
> Sorry to hasten but I'm wondering if there is a plan to cut the 5.16
> ethtool release? Looks like there is a problem in SFP EEPROM parsing
> code, at least with QSFP28s, user space always requests page 3 now.
> This ends in an -EINVAL (at least for drivers not supporting the paged
> mode).
>
> By the looks of it - Ido fixed this in 6e2b32a0d0ea ("sff-8636: Request
> specific pages for parsing in netlink path") but it may be too much code
> to backport so I'm thinking it's easiest for distros to move to v5.16.
Accidentally, I'm working on it right now. I need to run few more tests,
should be done in 20-30 minutes (if there are no complications).
Michal
next prev parent reply other threads:[~2022-01-18 23:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 22:51 ethtool 5.16 release / ethtool -m bug fix Jakub Kicinski
2022-01-18 23:14 ` Michal Kubecek [this message]
2022-01-18 23:54 ` Jakub Kicinski
2022-01-19 9:45 ` Ido Schimmel
2022-01-19 15:39 ` Jakub Kicinski
2022-01-20 7:54 ` Ido Schimmel
2022-01-20 17:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118231423.aa66a42vso3hvobp@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=dcavalca@fb.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=michel@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox