From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: Michal Kubecek <mkubecek@suse.cz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
michel@fb.com, dcavalca@fb.com, Andrew Lunn <andrew@lunn.ch>
Subject: Re: ethtool 5.16 release / ethtool -m bug fix
Date: Thu, 20 Jan 2022 09:30:51 -0800 [thread overview]
Message-ID: <20220120093051.70845141@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <YekVLcKZxa7ojNYc@shredder>
On Thu, 20 Jan 2022 09:54:21 +0200 Ido Schimmel wrote:
> > What about drivers which do implement get_module_eeprom_by_page? Can we
> > somehow ensure they DTRT and are consistent with the legacy / flat API?
>
> Not sure what you mean by that (I believe they are already doing the
> right thing). Life is much easier for drivers that implement
> get_module_eeprom_by_page() because they only need to fetch the
> information user space is asking for. They need not perform any parsing
> of the data, unlike in the legacy callbacks.
I see, my concern was that overzealous driver or FW may try to validate
the page number rather than just performing the read.
prev parent reply other threads:[~2022-01-20 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 22:51 ethtool 5.16 release / ethtool -m bug fix Jakub Kicinski
2022-01-18 23:14 ` Michal Kubecek
2022-01-18 23:54 ` Jakub Kicinski
2022-01-19 9:45 ` Ido Schimmel
2022-01-19 15:39 ` Jakub Kicinski
2022-01-20 7:54 ` Ido Schimmel
2022-01-20 17:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120093051.70845141@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=dcavalca@fb.com \
--cc=idosch@idosch.org \
--cc=michel@fb.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox