From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Nikolay Aleksandrov <nikolay@nvidia.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Roopa Prabhu <roopa@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Ido Schimmel <idosch@nvidia.com>,
Rafael Richter <rafael.richter@gin.de>,
Daniel Klauer <daniel.klauer@gin.de>,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [PATCH v2 net-next 1/8] net: bridge: vlan: notify switchdev only when something changed
Date: Tue, 15 Feb 2022 15:52:02 +0000 [thread overview]
Message-ID: <20220215155202.vfrg2xbxtetpdk6q@skbuf> (raw)
In-Reply-To: <49709ba6-7f4f-493d-88c9-553d7c300397@nvidia.com>
On Tue, Feb 15, 2022 at 05:44:52PM +0200, Nikolay Aleksandrov wrote:
> > Would you mind if I added an extra patch that also does this (it would
> > also remove the need for this check in drivers, plus it would change the
> > definition of "changed" to something IMO more reasonable, i.e. a master
> > VLAN that isn't brentry doesn't really exist, so even though the
> > !BRENTRY->BRENTRY is a flag change, it isn't a change of a switchdev
> > VLAN object that anybody offloads), or is there some reason I'm missing?
>
> I agree, patch looks good to me. I see that everyone already filters the
> !BRENTRY case anyway.
Thanks, this simplifies things quite a bit.
next prev parent reply other threads:[~2022-02-15 15:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 23:31 [PATCH v2 net-next 0/8] Replay and offload host VLAN entries in DSA Vladimir Oltean
2022-02-14 23:31 ` [PATCH v2 net-next 1/8] net: bridge: vlan: notify switchdev only when something changed Vladimir Oltean
2022-02-15 0:05 ` Vladimir Oltean
2022-02-15 8:54 ` Nikolay Aleksandrov
2022-02-15 9:54 ` Vladimir Oltean
2022-02-15 10:10 ` Vladimir Oltean
2022-02-15 10:15 ` Nikolay Aleksandrov
2022-02-15 10:12 ` Nikolay Aleksandrov
2022-02-15 10:30 ` Vladimir Oltean
2022-02-15 11:08 ` Nikolay Aleksandrov
2022-02-15 11:10 ` Nikolay Aleksandrov
2022-02-15 14:36 ` Vladimir Oltean
2022-02-15 15:38 ` Vladimir Oltean
2022-02-15 15:44 ` Nikolay Aleksandrov
2022-02-15 15:52 ` Vladimir Oltean [this message]
2022-02-14 23:31 ` [PATCH v2 net-next 2/8] net: bridge: switchdev: differentiate new VLANs from changed ones Vladimir Oltean
2022-02-14 23:31 ` [PATCH v2 net-next 3/8] net: bridge: make nbp_switchdev_unsync_objs() follow reverse order of sync() Vladimir Oltean
2022-02-14 23:31 ` [PATCH v2 net-next 4/8] net: bridge: switchdev: replay all VLAN groups Vladimir Oltean
2022-02-14 23:31 ` [PATCH v2 net-next 5/8] net: switchdev: rename switchdev_lower_dev_find to switchdev_lower_dev_find_rcu Vladimir Oltean
2022-02-14 23:31 ` [PATCH v2 net-next 6/8] net: switchdev: introduce switchdev_handle_port_obj_{add,del} for foreign interfaces Vladimir Oltean
2022-02-14 23:31 ` [PATCH v2 net-next 7/8] net: dsa: add explicit support for host bridge VLANs Vladimir Oltean
2022-02-14 23:31 ` [PATCH v2 net-next 8/8] net: dsa: offload bridge port VLANs on foreign interfaces Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215155202.vfrg2xbxtetpdk6q@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=daniel.klauer@gin.de \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=rafael.richter@gin.de \
--cc=roopa@nvidia.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox