From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Alexander Lobakin <alobakin@pm.me>,
Eric Dumazet <edumazet@google.com>,
Paul Blakey <paulb@nvidia.com>,
Yoshiki Komachi <komachi.yoshiki@gmail.com>,
zhang kai <zhangkaiheb@126.com>,
Juhee Kang <claudiajkang@gmail.com>,
Andreas Oetken <ennoerlangen@gmail.com>,
George McCollister <george.mccollister@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Anthony Harivel <anthony.harivel@linutronix.de>
Subject: Re: [PATCH net-next] flow_dissector: Add support for HSRv0
Date: Thu, 10 Mar 2022 13:34:03 +0000 [thread overview]
Message-ID: <20220310133403.bjf2k4tgpwl5xtsy@skbuf> (raw)
In-Reply-To: <20220310073505.49990-1-kurt@linutronix.de>
On Thu, Mar 10, 2022 at 08:35:05AM +0100, Kurt Kanzenbach wrote:
> Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for
> HSR within the flow dissector. However, it only works for HSR in version
> 1. Version 0 uses a different Ether Type. Add support for it.
>
> Reported-by: Anthony Harivel <anthony.harivel@linutronix.de>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
This observation came up as a result of the fact that HSRv0 is still in
actual use, or just for correctness' sake?
> ---
> net/core/flow_dissector.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 34441a32e3be..03b6e649c428 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -1283,6 +1283,7 @@ bool __skb_flow_dissect(const struct net *net,
> break;
> }
>
> + case htons(ETH_P_PRP):
> case htons(ETH_P_HSR): {
> struct hsr_tag *hdr, _hdr;
>
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-03-10 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 7:35 [PATCH net-next] flow_dissector: Add support for HSRv0 Kurt Kanzenbach
2022-03-10 13:34 ` Vladimir Oltean [this message]
2022-03-10 13:46 ` Kurt Kanzenbach
2022-03-11 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310133403.bjf2k4tgpwl5xtsy@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=alobakin@pm.me \
--cc=anthony.harivel@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=claudiajkang@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ennoerlangen@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=gustavoars@kernel.org \
--cc=komachi.yoshiki@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=paulb@nvidia.com \
--cc=zhangkaiheb@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox