* [PATCH net-next] flow_dissector: Add support for HSRv0
@ 2022-03-10 7:35 Kurt Kanzenbach
2022-03-10 13:34 ` Vladimir Oltean
2022-03-11 11:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Kurt Kanzenbach @ 2022-03-10 7:35 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: Gustavo A. R. Silva, Alexander Lobakin, Vladimir Oltean,
Eric Dumazet, Paul Blakey, Yoshiki Komachi, zhang kai, Juhee Kang,
Andreas Oetken, George McCollister, Sebastian Andrzej Siewior,
netdev, Kurt Kanzenbach, Anthony Harivel
Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for
HSR within the flow dissector. However, it only works for HSR in version
1. Version 0 uses a different Ether Type. Add support for it.
Reported-by: Anthony Harivel <anthony.harivel@linutronix.de>
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
net/core/flow_dissector.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 34441a32e3be..03b6e649c428 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -1283,6 +1283,7 @@ bool __skb_flow_dissect(const struct net *net,
break;
}
+ case htons(ETH_P_PRP):
case htons(ETH_P_HSR): {
struct hsr_tag *hdr, _hdr;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] flow_dissector: Add support for HSRv0
2022-03-10 7:35 [PATCH net-next] flow_dissector: Add support for HSRv0 Kurt Kanzenbach
@ 2022-03-10 13:34 ` Vladimir Oltean
2022-03-10 13:46 ` Kurt Kanzenbach
2022-03-11 11:10 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Vladimir Oltean @ 2022-03-10 13:34 UTC (permalink / raw)
To: Kurt Kanzenbach
Cc: David S. Miller, Jakub Kicinski, Gustavo A. R. Silva,
Alexander Lobakin, Eric Dumazet, Paul Blakey, Yoshiki Komachi,
zhang kai, Juhee Kang, Andreas Oetken, George McCollister,
Sebastian Andrzej Siewior, netdev@vger.kernel.org,
Anthony Harivel
On Thu, Mar 10, 2022 at 08:35:05AM +0100, Kurt Kanzenbach wrote:
> Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for
> HSR within the flow dissector. However, it only works for HSR in version
> 1. Version 0 uses a different Ether Type. Add support for it.
>
> Reported-by: Anthony Harivel <anthony.harivel@linutronix.de>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
This observation came up as a result of the fact that HSRv0 is still in
actual use, or just for correctness' sake?
> ---
> net/core/flow_dissector.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 34441a32e3be..03b6e649c428 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -1283,6 +1283,7 @@ bool __skb_flow_dissect(const struct net *net,
> break;
> }
>
> + case htons(ETH_P_PRP):
> case htons(ETH_P_HSR): {
> struct hsr_tag *hdr, _hdr;
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] flow_dissector: Add support for HSRv0
2022-03-10 13:34 ` Vladimir Oltean
@ 2022-03-10 13:46 ` Kurt Kanzenbach
0 siblings, 0 replies; 4+ messages in thread
From: Kurt Kanzenbach @ 2022-03-10 13:46 UTC (permalink / raw)
To: Vladimir Oltean
Cc: David S. Miller, Jakub Kicinski, Gustavo A. R. Silva,
Alexander Lobakin, Eric Dumazet, Paul Blakey, Yoshiki Komachi,
zhang kai, Juhee Kang, Andreas Oetken, George McCollister,
Sebastian Andrzej Siewior, netdev@vger.kernel.org,
Anthony Harivel
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Thu Mar 10 2022, Vladimir Oltean wrote:
> On Thu, Mar 10, 2022 at 08:35:05AM +0100, Kurt Kanzenbach wrote:
>> Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for
>> HSR within the flow dissector. However, it only works for HSR in version
>> 1. Version 0 uses a different Ether Type. Add support for it.
>>
>> Reported-by: Anthony Harivel <anthony.harivel@linutronix.de>
>> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
>
> This observation came up as a result of the fact that HSRv0 is still in
> actual use, or just for correctness' sake?
It came up while testing the Linux HSR implementation.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] flow_dissector: Add support for HSRv0
2022-03-10 7:35 [PATCH net-next] flow_dissector: Add support for HSRv0 Kurt Kanzenbach
2022-03-10 13:34 ` Vladimir Oltean
@ 2022-03-11 11:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-11 11:10 UTC (permalink / raw)
To: Kurt Kanzenbach
Cc: davem, kuba, gustavoars, alobakin, vladimir.oltean, edumazet,
paulb, komachi.yoshiki, zhangkaiheb, claudiajkang, ennoerlangen,
george.mccollister, bigeasy, netdev, anthony.harivel
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 10 Mar 2022 08:35:05 +0100 you wrote:
> Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for
> HSR within the flow dissector. However, it only works for HSR in version
> 1. Version 0 uses a different Ether Type. Add support for it.
>
> Reported-by: Anthony Harivel <anthony.harivel@linutronix.de>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
>
> [...]
Here is the summary with links:
- [net-next] flow_dissector: Add support for HSRv0
https://git.kernel.org/netdev/net-next/c/f65e58440d4f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-11 11:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-10 7:35 [PATCH net-next] flow_dissector: Add support for HSRv0 Kurt Kanzenbach
2022-03-10 13:34 ` Vladimir Oltean
2022-03-10 13:46 ` Kurt Kanzenbach
2022-03-11 11:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox