* [PATCH net-next] net: sparx5: fix a couple warning messages
@ 2022-03-14 14:03 Dan Carpenter
2022-03-15 15:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-03-14 14:03 UTC (permalink / raw)
To: David S. Miller, Horatiu Vultur
Cc: Jakub Kicinski, Lars Povlsen, Steen Hegelund, UNGLinuxDriver,
netdev, kernel-janitors
The WARN_ON() macro takes a condition, not a warning message.
Fixes: 0933bd04047c ("net: sparx5: Add support for ptp clocks")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
index cd110c31e5a4..0ed1ea7727c5 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
@@ -45,7 +45,7 @@ static u64 sparx5_ptp_get_1ppm(struct sparx5 *sparx5)
res = 920535763834;
break;
default:
- WARN_ON("Invalid core clock");
+ WARN(1, "Invalid core clock");
break;
}
@@ -67,7 +67,7 @@ static u64 sparx5_ptp_get_nominal_value(struct sparx5 *sparx5)
res = 0x0CC6666666666666;
break;
default:
- WARN_ON("Invalid core clock");
+ WARN(1, "Invalid core clock");
break;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: sparx5: fix a couple warning messages
2022-03-14 14:03 [PATCH net-next] net: sparx5: fix a couple warning messages Dan Carpenter
@ 2022-03-15 15:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-15 15:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: davem, horatiu.vultur, kuba, lars.povlsen, Steen.Hegelund,
UNGLinuxDriver, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 14 Mar 2022 17:03:27 +0300 you wrote:
> The WARN_ON() macro takes a condition, not a warning message.
>
> Fixes: 0933bd04047c ("net: sparx5: Add support for ptp clocks")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net-next] net: sparx5: fix a couple warning messages
https://git.kernel.org/netdev/net-next/c/c24f657791fd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-15 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-14 14:03 [PATCH net-next] net: sparx5: fix a couple warning messages Dan Carpenter
2022-03-15 15:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox