* [PATCH net-next] net: dsa: Never offload FDB entries on standalone ports
@ 2022-03-15 22:50 Tobias Waldekranz
2022-03-15 23:00 ` Vladimir Oltean
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Waldekranz @ 2022-03-15 22:50 UTC (permalink / raw)
To: davem, kuba
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
netdev, linux-kernel
If a port joins a bridge that it can't offload, it will fallback to
standalone mode and software bridging. In this case, we never want to
offload any FDB entries to hardware either.
Fixes: c26933639b54 ("net: dsa: request drivers to perform FDB isolation")
Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
---
net/dsa/slave.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index f9cecda791d5..d24b6bf845c1 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -2847,6 +2847,9 @@ static int dsa_slave_fdb_event(struct net_device *dev,
if (ctx && ctx != dp)
return 0;
+ if (!dp->bridge)
+ return 0;
+
if (switchdev_fdb_is_dynamically_learned(fdb_info)) {
if (dsa_port_offloads_bridge_port(dp, orig_dev))
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: dsa: Never offload FDB entries on standalone ports
2022-03-15 22:50 [PATCH net-next] net: dsa: Never offload FDB entries on standalone ports Tobias Waldekranz
@ 2022-03-15 23:00 ` Vladimir Oltean
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Oltean @ 2022-03-15 23:00 UTC (permalink / raw)
To: Tobias Waldekranz
Cc: davem, kuba, Andrew Lunn, Vivien Didelot, Florian Fainelli,
netdev, linux-kernel
On Tue, Mar 15, 2022 at 11:50:18PM +0100, Tobias Waldekranz wrote:
> If a port joins a bridge that it can't offload, it will fallback to
> standalone mode and software bridging. In this case, we never want to
> offload any FDB entries to hardware either.
>
> Fixes: c26933639b54 ("net: dsa: request drivers to perform FDB isolation")
Do you mind if you resend and you explain in the commit message what is
the impact and why you chose this Fixes: tag?
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> ---
> net/dsa/slave.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index f9cecda791d5..d24b6bf845c1 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -2847,6 +2847,9 @@ static int dsa_slave_fdb_event(struct net_device *dev,
> if (ctx && ctx != dp)
> return 0;
>
> + if (!dp->bridge)
> + return 0;
> +
> if (switchdev_fdb_is_dynamically_learned(fdb_info)) {
> if (dsa_port_offloads_bridge_port(dp, orig_dev))
> return 0;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-15 23:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-15 22:50 [PATCH net-next] net: dsa: Never offload FDB entries on standalone ports Tobias Waldekranz
2022-03-15 23:00 ` Vladimir Oltean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox