* [PATCH] vxlan: fix returnvar.cocci warnings
[not found] <202203212331.4ZEJaAXK-lkp@intel.com>
@ 2022-03-21 15:44 ` kernel test robot
2022-03-21 19:16 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-03-21 15:44 UTC (permalink / raw)
To: Roopa Prabhu
Cc: kbuild-all, Linux Memory Management List, Jakub Kicinski,
Eric Dumazet, Sebastian Andrzej Siewior, Eelco Chaudron,
Ido Schimmel, netdev, linux-kernel
From: kernel test robot <lkp@intel.com>
drivers/net/vxlan/vxlan_core.c:2962:5-8: Unneeded variable: "ret". Return "0" on line 2971
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device")
CC: Roopa Prabhu <roopa@nvidia.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 6d72dda014a4753974eb08950089ddf71fec4f60
commit: f9c4bb0b245cee35ef66f75bf409c9573d934cf9 [8808/13988] vxlan: vni filtering support on collect metadata device
:::::: branch date: 3 days ago
:::::: commit date: 3 weeks ago
drivers/net/vxlan/vxlan_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -2959,7 +2959,6 @@ static void vxlan_flush(struct vxlan_dev
static int vxlan_stop(struct net_device *dev)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
- int ret = 0;
vxlan_multicast_leave(vxlan);
@@ -2968,7 +2967,7 @@ static int vxlan_stop(struct net_device
vxlan_flush(vxlan, false);
vxlan_sock_release(vxlan);
- return ret;
+ return 0;
}
/* Stub, nothing needs to be done. */
^ permalink raw reply [flat|nested] 2+ messages in thread