Netdev List
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
	petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com,
	vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com,
	baowen.zheng@corigine.com, marcelo.leitner@gmail.com,
	Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 06/14] net/sched: act_mpls: Add extack messages for offload failure
Date: Thu,  7 Apr 2022 10:35:25 +0300	[thread overview]
Message-ID: <20220407073533.2422896-7-idosch@nvidia.com> (raw)
In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com>

For better error reporting to user space, add extack messages when mpls
action offload fails.

Example:

 # echo 1 > /sys/kernel/tracing/events/netlink/netlink_extack/enable

 # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action mpls dec_ttl
 Error: cls_matchall: Failed to setup flow action.
 We have an error talking to the kernel

 # cat /sys/kernel/tracing/trace_pipe
       tc-182     [000] b..1.    18.693915: netlink_extack: msg=act_mpls: Offload not supported when "dec_ttl" option is used
       tc-182     [000] .....    18.693921: netlink_extack: msg=cls_matchall: Failed to setup flow action

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
---
 net/sched/act_mpls.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/net/sched/act_mpls.c b/net/sched/act_mpls.c
index 23fcfa5605df..adabeccb63e1 100644
--- a/net/sched/act_mpls.c
+++ b/net/sched/act_mpls.c
@@ -411,7 +411,14 @@ static int tcf_mpls_offload_act_setup(struct tc_action *act, void *entry_data,
 			entry->mpls_mangle.bos = tcf_mpls_bos(act);
 			entry->mpls_mangle.ttl = tcf_mpls_ttl(act);
 			break;
+		case TCA_MPLS_ACT_DEC_TTL:
+			NL_SET_ERR_MSG_MOD(extack, "Offload not supported when \"dec_ttl\" option is used");
+			return -EOPNOTSUPP;
+		case TCA_MPLS_ACT_MAC_PUSH:
+			NL_SET_ERR_MSG_MOD(extack, "Offload not supported when \"mac_push\" option is used");
+			return -EOPNOTSUPP;
 		default:
+			NL_SET_ERR_MSG_MOD(extack, "Unsupported MPLS mode offload");
 			return -EOPNOTSUPP;
 		}
 		*index_inc = 1;
-- 
2.33.1


  parent reply	other threads:[~2022-04-07  7:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  7:35 [PATCH net-next 00/14] net/sched: Better error reporting for offload failures Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 01/14] net/sched: matchall: Take verbose flag into account when logging error messages Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 02/14] net/sched: flower: " Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 03/14] net/sched: act_api: Add extack to offload_act_setup() callback Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 04/14] net/sched: act_gact: Add extack messages for offload failure Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 05/14] net/sched: act_mirred: Add extack message " Ido Schimmel
2022-04-07  7:35 ` Ido Schimmel [this message]
2022-04-07  7:35 ` [PATCH net-next 07/14] net/sched: act_pedit: " Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 08/14] net/sched: act_police: Add extack messages " Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 09/14] net/sched: act_skbedit: " Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 10/14] net/sched: act_tunnel_key: Add extack message " Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 11/14] net/sched: act_vlan: " Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 12/14] net/sched: cls_api: Add extack message for unsupported action offload Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 13/14] net/sched: matchall: Avoid overwriting error messages Ido Schimmel
2022-04-07  7:35 ` [PATCH net-next 14/14] net/sched: flower: " Ido Schimmel
2022-04-07 21:15 ` [PATCH net-next 00/14] net/sched: Better error reporting for offload failures Jamal Hadi Salim
2022-04-08 12:50 ` patchwork-bot+netdevbpf
2022-04-08 18:51 ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407073533.2422896-7-idosch@nvidia.com \
    --to=idosch@nvidia.com \
    --cc=baowen.zheng@corigine.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jianbol@nvidia.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=roid@nvidia.com \
    --cc=simon.horman@corigine.com \
    --cc=vladbu@nvidia.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox