From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com,
roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com,
simon.horman@corigine.com, baowen.zheng@corigine.com
Subject: Re: [PATCH net-next 00/14] net/sched: Better error reporting for offload failures
Date: Fri, 8 Apr 2022 15:51:27 -0300 [thread overview]
Message-ID: <YlCEL1tW8lu0yRtC@t14s.localdomain> (raw)
In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com>
On Thu, Apr 07, 2022 at 10:35:19AM +0300, Ido Schimmel wrote:
> This patchset improves error reporting to user space when offload fails
> during the flow action setup phase. That is, when failures occur in the
> actions themselves, even before calling device drivers. Requested /
> reported in [1].
>
> This is done by passing extack to the offload_act_setup() callback and
> making use of it in the various actions.
>
> Patches #1-#2 change matchall and flower to log error messages to user
> space in accordance with the verbose flag.
>
> Patch #3 passes extack to the offload_act_setup() callback from the
> various call sites, including matchall and flower.
>
> Patches #4-#11 make use of extack in the various actions to report
> offload failures.
>
> Patch #12 adds an error message when the action does not support offload
> at all.
>
> Patches #13-#14 change matchall and flower to stop overwriting more
> specific error messages.
>
> [1] https://lore.kernel.org/netdev/20220317185249.5mff5u2x624pjewv@skbuf/
Seems like tc is almost becoming user friendly!? :)
post-merge review FWIW,
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
prev parent reply other threads:[~2022-04-08 18:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 7:35 [PATCH net-next 00/14] net/sched: Better error reporting for offload failures Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 01/14] net/sched: matchall: Take verbose flag into account when logging error messages Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 02/14] net/sched: flower: " Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 03/14] net/sched: act_api: Add extack to offload_act_setup() callback Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 04/14] net/sched: act_gact: Add extack messages for offload failure Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 05/14] net/sched: act_mirred: Add extack message " Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 06/14] net/sched: act_mpls: Add extack messages " Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 07/14] net/sched: act_pedit: Add extack message " Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 08/14] net/sched: act_police: Add extack messages " Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 09/14] net/sched: act_skbedit: " Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 10/14] net/sched: act_tunnel_key: Add extack message " Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 11/14] net/sched: act_vlan: " Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 12/14] net/sched: cls_api: Add extack message for unsupported action offload Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 13/14] net/sched: matchall: Avoid overwriting error messages Ido Schimmel
2022-04-07 7:35 ` [PATCH net-next 14/14] net/sched: flower: " Ido Schimmel
2022-04-07 21:15 ` [PATCH net-next 00/14] net/sched: Better error reporting for offload failures Jamal Hadi Salim
2022-04-08 12:50 ` patchwork-bot+netdevbpf
2022-04-08 18:51 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlCEL1tW8lu0yRtC@t14s.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=baowen.zheng@corigine.com \
--cc=davem@davemloft.net \
--cc=idosch@nvidia.com \
--cc=jhs@mojatatu.com \
--cc=jianbol@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=roid@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox