From: Christian Brauner <brauner@kernel.org>
To: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
Cc: netdev@vger.kernel.org, dev@openvswitch.org, pshelar@ovn.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, ptikhomirov@virtuozzo.com,
alexander.mikhalitsyn@virtuozzo.com, avagin@google.com
Subject: Re: [PATCH net-next 1/1] openvswitch: allow specifying ifindex of new interfaces
Date: Wed, 17 Aug 2022 15:18:41 +0200 [thread overview]
Message-ID: <20220817131841.frtdyro52bsus2h5@wittgenstein> (raw)
In-Reply-To: <20220817124909.83373-2-andrey.zhadchenko@virtuozzo.com>
On Wed, Aug 17, 2022 at 03:49:09PM +0300, Andrey Zhadchenko wrote:
> CRIU is preserving ifindexes of net devices after restoration. However,
> current Open vSwitch API does not allow to target ifindex, so we cannot
> correctly restore OVS configuration.
>
> Use ovs_header->dp_ifindex during OVS_DP_CMD_NEW as desired ifindex.
> Use OVS_VPORT_ATTR_IFINDEX during OVS_VPORT_CMD_NEW to specify new netdev
> ifindex.
>
> Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
> ---
I think specifying the index at device creation time is a good idea and
iirc then we do allow this for veth devices already. So I'd be happy to
see this go forwad.
next prev parent reply other threads:[~2022-08-17 13:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 12:49 [PATCH net-next 0/1] openvswitch: allow specifying ifindex of new interfaces Andrey Zhadchenko
2022-08-17 12:49 ` [PATCH net-next 1/1] " Andrey Zhadchenko
2022-08-17 13:18 ` Christian Brauner [this message]
2022-08-17 13:09 ` [PATCH net-next 0/1] " Christian Brauner
2022-08-17 18:19 ` [ovs-dev] " Ilya Maximets
2022-08-17 20:35 ` Andrey Zhadchenko
2022-08-17 22:15 ` Ilya Maximets
2022-08-17 23:11 ` Andrey Zhadchenko
2022-08-18 11:06 ` Ilya Maximets
2022-08-18 12:26 ` Andrey Zhadchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817131841.frtdyro52bsus2h5@wittgenstein \
--to=brauner@kernel.org \
--cc=alexander.mikhalitsyn@virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=avagin@google.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=ptikhomirov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox