From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>
Subject: Re: [PATCH v2 net-next 8/9] net: mscc: ocelot: set up tag_8021q CPU ports independent of user port affinity
Date: Fri, 19 Aug 2022 16:44:14 +0000 [thread overview]
Message-ID: <20220819164413.bjpc6fz3yy6jwupt@skbuf> (raw)
In-Reply-To: <Yv+W3IhA0d/0mzEq@euler>
On Fri, Aug 19, 2022 at 06:57:48AM -0700, Colin Foster wrote:
> https://patchwork.kernel.org/project/netdevbpf/patch/20220508185313.2222956-9-colin.foster@in-advantage.com/#24849610
>
> From there:
>
> > +EXPORT_SYMBOL(ocelot_chip_reset);
>
> Please, switch to the namespace (_NS) variant of the exported-imported
> symbols for these drivers.
>
>
> I'm not sure the full motivation. But I agree, I can't imagine anyone
> else randomly naming and exporting another function of that name.
>
> Just thought I'd ask.
Ok, I'm not going to namespace a new symbol when 62 others from ocelot.c
alone aren't. I'll ask Andy what was the intention if I manage to find
that email in my inbox, and maybe I'll consider namespacing them
separately.
next prev parent reply other threads:[~2022-08-19 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 13:52 [PATCH v2 net-next 0/9] DSA changes for multiple CPU ports (part 3) Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 1/9] net: dsa: walk through all changeupper notifier functions Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 2/9] net: dsa: don't stop at NOTIFY_OK when calling ds->ops->port_prechangeupper Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 3/9] net: bridge: move DSA master bridging restriction to DSA Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 4/9] net: dsa: existing DSA masters cannot join upper interfaces Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 5/9] net: dsa: only bring down user ports assigned to a given DSA master Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 6/9] net: dsa: all DSA masters must be down when changing the tagging protocol Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 7/9] net: dsa: use dsa_tree_for_each_cpu_port in dsa_tree_{setup,teardown}_master Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 8/9] net: mscc: ocelot: set up tag_8021q CPU ports independent of user port affinity Vladimir Oltean
2022-08-19 3:58 ` Jakub Kicinski
2022-08-19 11:06 ` Vladimir Oltean
2022-08-19 13:37 ` Colin Foster
2022-08-19 13:39 ` Vladimir Oltean
2022-08-19 13:45 ` Colin Foster
2022-08-19 13:48 ` Vladimir Oltean
2022-08-19 13:57 ` Colin Foster
2022-08-19 16:44 ` Vladimir Oltean [this message]
2022-08-18 13:52 ` [PATCH v2 net-next 9/9] net: mscc: ocelot: adjust forwarding domain for CPU ports in a LAG Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819164413.bjpc6fz3yy6jwupt@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox